[Bug] Class editor: allowed-classes select shows duplicate options and drops classes (folder nodes leak into options)

[alexbaat]

Changes in this pull request

Resolves pimcore/platform-version#239

useClassDefinitionOptions builds the options for the allowed classes select shown in the class editor settings of all relation field types (manyToOneRelation, manyToManyRelation, manyToManyObjectRelation, both advanced* variants and reverseObjectRelation). It fetches the class definition tree with withGroup: true and flattens it — but flattenTreeNodes() emitted the folder (group) nodes themselves as selectable options in addition to their children.

Since ClassDefinitionTreeService (studio-backend-bundle) derives group names from class name prefixes for classes without an explicit group, a folder is frequently named exactly like a real class. Example: classes Material and MaterialGroup are grouped into a folder named Material, so the options contain Material twice (folder + class) plus phantom entries for groups that are not classes at all (Royalty, …).

Observed behaviour

• The allowed-classes dropdown shows duplicate entries (e.g. Material twice, Product twice).
• The duplicate option values / React keys break rendering of the virtualized dropdown list, so some perfectly valid classes (e.g. Series) no longer show up and cannot be selected.
• Folder/group names can be picked and saved as an "allowed class" even though no such class exists.

Reproduction

1. Create classes Material, MaterialGroup and Series (no explicit group set).
2. Add a manyToOneRelation field to any class and open its settings in the class editor.
3. Open the Allowed classes select: Material appears twice, Series is missing.

Fix

Skip folder nodes in flattenTreeNodes() and only recurse into their children — folders are grouping containers, not selectable class definitions. This mirrors what the neighbouring useClassRelationFieldsOptions hook already does. The special folder option added via the includeFolder parameter is unaffected.

Added a Jest spec covering: folder nodes excluded, no duplicate values when a folder shares its name with a class, includeFolder behaviour, and the not-yet-loaded state.

Additional info

The root cause has two halves: the prefix-based auto-grouping in ClassDefinitionTreeService::extractGroupNameFromClassName() (studio-backend-bundle) is what makes folder names collide with class names in the first place. This PR fixes the consumer side, which resolves the user-facing bug for all relation field types; rethinking the prefix grouping itself is left out of scope.

Reproduced on v2026.1.6 and the bug is still present on 2026.x/v2026.2.1.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[Copilot]

Pull request overview

Fixes invalid and duplicate class options in relation field settings by excluding grouping folders.

Changes:

• Flattens only actual class-definition nodes.
• Adds regression tests for duplicates, folder inclusion, and unloaded data.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
use-class-definition-options.ts	Excludes folder nodes from selectable options.
use-class-definition-options.spec.ts	Adds regression coverage for option generation.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[alexbaat]

recheck

[alexbaat]

I have read the CLA Document and I hereby sign the CLA