Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10631

What problem does this PR solve?

Issue Number: ref #10634

Problem Summary:

What is changed and how it works?

* Performance metrics
  * Metrics when tiflash-compute doing delta-index place, whether the delta-index are reuse or updated, the rows and deletes updated
  * Metrics when S3RandomAccessFile read/seek meet error
  * The number of active SegmentReadTask 
* Remote Object Storage summary
  * Add a http api "http://${TIFLASH_IP}:${TIFLASH_STATUS_PORT}/tiflash/remote/info" for fetching the object storage summary from tiflash-write node

New added panels

  • "Storage Read Pool & Data Sharing", panels about read tasks
image * "Disaggregated-Compute", panels about place index image * "S3", panels about S3RandomeAccessFile image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
# Run chbenchmark on chbenchmark 8000
tiup bench ch --host 10.2.12.81 -P 8081 --warehouses 8000 run -D chbenchmark8k -T 50 -t 2 --time 60m --ignore-error --queries q1
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Dec 29, 2025
@ti-chi-bot
Copy link
Member Author

@JaySon-Huang This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: JaySon-Huang <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 29, 2025
@JaySon-Huang
Copy link
Contributor

/unhold
conflict are resolved

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 29, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-29 03:01:30.315342564 +0000 UTC m=+2651635.129120136: ☑️ agreed by JinheLin.
  • 2025-12-29 03:36:16.297284464 +0000 UTC m=+2653721.111062026: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 29, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin, kolafish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2025

@kolafish: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit a8494a9 into pingcap:release-nextgen-20251011 Dec 29, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-10631-to-release-nextgen-20251011 branch December 29, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants