Skip to content

Storages: downgrade some logs (#10815) #10839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 1 commit into from
May 11, 2026
+1 −1
Merged

Storages: downgrade some logs (#10815) #10839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbms/src/Storages/DeltaMerge/ReadThread/SegmentReadTaskScheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ void SegmentReadTaskScheduler::submitPendingPool(SegmentReadTaskPoolPtr pool)
Stopwatch sw;
std::lock_guard lock(pending_mtx);
pending_pools.push_back(pool);
LOG_INFO(
LOG_DEBUG(
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Restore LOG_INFO for storage scheduler submission logs

Line 71 downgrades a storage-engine scheduler event to LOG_DEBUG, which conflicts with the repository logging rule for this path. Please keep this as LOG_INFO (or document/adjust the guideline if this downgrade is intentional for release branches).

As per coding guidelines: "dbms/src/Storages/**/{DeltaMerge,KVStore,Page,S3}/**/*.{h,hpp,cpp}: Use LoggerPtr and LOG_INFO(log, ...) with relevant context."

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dbms/src/Storages/DeltaMerge/ReadThread/SegmentReadTaskScheduler.cpp` at line
71, The log call in SegmentReadTaskScheduler was downgraded to LOG_DEBUG;
restore it to LOG_INFO per storage-engine logging guidelines. Replace the
LOG_DEBUG(...) invocation in the SegmentReadTaskScheduler submission path with
LOG_INFO(log, ...) (using the existing LoggerPtr named log) so submission events
are logged at INFO level; ensure the surrounding context/message remains
unchanged and uses the same variables passed to the original call.

pool->getLogger(),
"Submitted, pool_id={} segment_count={} pending_pools={} cost={}ns",
pool->pool_id,
Expand Down