Skip to content

Conversation

@Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

close #xxx

What is changed and how it works?

Support tikv-worker in TiUP Cluster.

Since there is no tikv-worker package right now, we need to scp tikv-worker binary to tikv-work deploy dir manually.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack January 21, 2026 06:52
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2026
@Lloyd-Pottiger Lloyd-Pottiger changed the title Cluster tikv worker cluster: support tikv-worker Jan 21, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 7.58621% with 134 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.17%. Comparing base (7d025cb) to head (ff3f264).

Files with missing lines Patch % Lines
pkg/cluster/spec/tikv_worker.go 6.14% 106 Missing and 1 partial ⚠️
pkg/cluster/template/scripts/tikv_worker.go 0.00% 12 Missing ⚠️
pkg/cluster/task/update_meta.go 0.00% 6 Missing ⚠️
pkg/cluster/spec/monitoring.go 0.00% 5 Missing ⚠️
pkg/cluster/template/config/prometheus.go 0.00% 3 Missing ⚠️
pkg/cluster/spec/spec.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
+ Coverage   42.15%   42.17%   +0.02%     
==========================================
  Files         424      426       +2     
  Lines       46888    47033     +145     
==========================================
+ Hits        19764    19833      +69     
- Misses      24473    24534      +61     
- Partials     2651     2666      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @xhebox @breezewish

@ti-chi-bot ti-chi-bot bot requested review from breezewish and xhebox January 21, 2026 07:14
@xhebox
Copy link
Collaborator

xhebox commented Jan 21, 2026

  // For some repos (e.g. internal ones), tikv-worker can be packaged as anextra binary inside the `tikv` component. Prefer checking with  `bin/tikv-worker` when it exists, otherwise fall back to the component's default entry.

The comment is true. Isn't this break that behavior?

@Lloyd-Pottiger
Copy link
Contributor Author

  // For some repos (e.g. internal ones), tikv-worker can be packaged as anextra binary inside the `tikv` component. Prefer checking with  `bin/tikv-worker` when it exists, otherwise fall back to the component's default entry.

The comment is true. Isn't this break that behavior?

http://tiup.pingcap.net:8988/ tikv-worker is an independent package.

@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as draft January 21, 2026 08:55
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants