Skip to content

fix(mobile): align Android terminal for 16KB pages #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Jun 29, 2026
Merged

fix(mobile): align Android terminal for 16KB pages #3595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/mobile/modules/t3-terminal/android/src/main/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,8 @@ target_include_directories(
PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/../../../../Vendor/libghostty-vt/include"
)

target_link_options(
t3terminal PRIVATE "-Wl,-z,common-page-size=16384" "-Wl,-z,max-page-size=16384"
)

target_link_libraries(t3terminal PRIVATE ghostty-vt log)
11 changes: 11 additions & 0 deletions ...-terminal/scripts/libghostty-android-patches/0002-align-android-libvt-to-16kb-pages.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
diff --git a/src/build/GhosttyLibVt.zig b/src/build/GhosttyLibVt.zig
--- a/src/build/GhosttyLibVt.zig
+++ b/src/build/GhosttyLibVt.zig
@@ -236,6 +236,7 @@ fn initLib(
if (lib.rootModuleTarget().abi.isAndroid()) {
// Support 16kb page sizes, required for Android 15+.
+ lib.link_z_common_page_size = 16384; // 16kb
lib.link_z_max_page_size = 16384; // 16kb

try @import("android_ndk").addPaths(b, lib);
}
Loading