feat(cloudrun): implement DetermineVersions for v1 plugin architectur…#6536
Open
moghit-eou wants to merge 1 commit intopipe-cd:masterfrom
Open
feat(cloudrun): implement DetermineVersions for v1 plugin architectur…#6536moghit-eou wants to merge 1 commit intopipe-cd:masterfrom
moghit-eou wants to merge 1 commit intopipe-cd:masterfrom
Conversation
…pipe-cd#6114 Signed-off-by: moghit-eou <moghit.elouaad1@gmail.com>
4601466 to
e6a10b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
DetermineVersionslifecycle method for the new Cloud Run v1 plugin.ImageVersionExtractionhelper function to handle diverse container image formats environments.CloudRunDeploymentInputstruct inapplication.goto include theimagefield required for version determination.plugin_test.goto verify the extraction logic against various real-world image strings.Why we need it:
The v1 plugin architecture requires explicit logic to identify artifact versions for the Control Plane. This implementation allows PipeCD to correctly populate the "Version" column in the Deployment UI, which is a core requirement for the Cloud Run v1 migration.
Which issue(s) this PR fixes:
Fixes #6114
Does this PR introduce a user-facing change?:
Yes.
imagefield within theinputsection of their Cloud Run application configuration. This enables PipeCD to track and display the specific container version being deployed.