MissingRemoteId: also check EGIT_REPO_URI #643
Conversation
Signed-off-by: Alfred Wingate <[email protected]>
parona-source
force-pushed
the
EGIT_REPO_URI_remoteid
branch
from
da2225e to
e4431da
Compare
| urls = urls.union(pkg.homepage) | ||
|
|
||
| if "git-r3" in pkg.inherited and hasattr(pkg, "environment"): | ||
| egit_repo_uri = re.compile(r"EGIT_REPO_URI=\"(.*)\"") |
There was a problem hiding this comment.
generally speaking, what you're up to here isn't safe due to bash being 'bash'. Minimally that has to be anchored to start/endline.
Personally, I'd rather not do regex on bash since it's not robust. EBD could be tweaked to spit back arbitrary requested variables which is far safer- as in, do the parse, then pull the raw value out of the bash env post render.
There may be other tooling for this that pkgcore/pkgcheck uses that I'm unaware of, however.
ferringb
left a comment
ferringb
left a comment
There was a problem hiding this comment.
Admittedly way the fuck late, but please give a repro command... preferably for modern pkgcheck. :)
I ran a quick pkgcheck against some ebuilds that had git-r3 as an inheritance- I could not see any reports generated related to this. IE, I need a modern repro please, unless this is no longer an issue..
2 participants
Making it a draft as I'd like input if on if there is a better way to do to get the value of EGIT_REPO_URI with pkgcore's API.
Also I'm unsure if I correctly added the test, also a test scenario where EGIT_REPO_URI isnt set in the ebuild itself would be good to add.
Keep in mind that I want get the value of the variable post inherit as eclasses like kde.org set it as well.