Added new Erply Api options Could include more#11
Open
hadi-14 wants to merge 1 commit intoplaes:mainfrom
Open
Conversation
plaes
requested changes
Oct 15, 2023
| """ | ||
| ErplyAPI | ||
| ~~~~~~~~ | ||
|
|
Owner
There was a problem hiding this comment.
Please keep existing empty lines in the docstrings. Please check PEP 257.
| ,'getProducts' | ||
| ,'getProductCategories' | ||
| ,'getProductCostForSpecificAmount' # untested | ||
| ,'getProductCostForSpecificAmount' |
| ,'getSalesDocuments' | ||
| ,'getServices' | ||
| ,'getWarehouses' | ||
| ,'getAllowedWarehouses' |
Owner
There was a problem hiding this comment.
This list is supposed to be alphabetically ordered.
| ) | ||
| ERPLY_CSV = ('getProductStockCSV', 'getSalesReport') | ||
| ERPLY_POST = ('saveProduct',) | ||
| ERPLY_CSV = ('getProductStockCSV', 'getSalesReport','getPurchaseReport') |
| ERPLY_CSV = ('getProductStockCSV', 'getSalesReport') | ||
| ERPLY_POST = ('saveProduct',) | ||
| ERPLY_CSV = ('getProductStockCSV', 'getSalesReport','getPurchaseReport') | ||
| ERPLY_POST = ('saveProduct') |
Owner
There was a problem hiding this comment.
The removed comma is needed as ERPLY_POST variable is filled with tuple of strings. With your change you turned it to just single string..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added some new api requests which I have tested. More could be added though