fix: improve error message when role command returns 404#1178
Merged
mscoutermarsh merged 2 commits intomainfrom Jan 13, 2026
Merged
fix: improve error message when role command returns 404#1178mscoutermarsh merged 2 commits intomainfrom
mscoutermarsh merged 2 commits intomainfrom
Conversation
3966f01 to
9e828a7
Compare
mscoutermarsh
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
role create- updated error messagerole list- updated error messagerole reset-default- updated error messageBefore
After
Question:
This follows the pattern used in
keyspace/create.goandkeyspace/list.go.An alternative approach would be to first check if the database exists (like
branch/show.godoes), which would allow more precise error messages. However, that adds an extra API call on the error path. Happy to implement that approach if preferred.