This repository was archived by the owner on Jun 23, 2026. It is now read-only.
Feat/migrate store in system apiexport#574
Open
OlegErshov wants to merge 11 commits into
Open
Conversation
On-behalf-of: SAP aleh.yarshou@sap.com Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com Signed-off-by: OlegErshov <olezhka1629@gmail.com>
On-behalf-of: SAP aleh.yarshou@sap.com Signed-off-by: OlegErshov <olezhka1629@gmail.com>
OlegErshov
force-pushed
the
feat/migrate-store-in-system-apiexport
branch
from
f1c8a09 to
699b198
Compare
Signed-off-by: OlegErshov <olezhka1629@gmail.com> On-behalf-of: SAP aleh.yarshou@sap.com
aaronschweig
left a comment
aaronschweig
left a comment
Contributor
There was a problem hiding this comment.
This is a breaking change for existing deployments, but the PR doesn't mention that. Could we add some context to the description and also some instructions regarding mitigation for existing deployments?
A few things worth documenting:
- Existing Store / AuthorizationModel resources under
core.platform-mesh.iowill stop reconciling once this is rolled out. - The
core.platform-mesh.io/fga-tuplesfinalizer on those resources could leave them stuck on delete if nothing cleans it up. - How would the migration strategy look like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: SAP aleh.yarshou@sap.com
[BREAKING CHANGE] Store resource has been moved from core.platform-mesh.io to system.platform-mesh.io apiexport. This PR supports this migration
Authorization models hasn't been changed as it was decided to leave them in user workspaces so they can be changed.
Migration strategy for existing environments:
Store reconciliation will be fine when ApiBindings are fine with new changes. Unfortunately kcp will not allow to re-bound already bounded resources. It means that it's not possible to fix ApiBindings without removing old ones. Removing ApiBinding leads to the removal of the all bounded in it resources. As system apiexport affects 2 workspaces
:root:orgs,:root:platform-mesh-systemfor environment update it's required to remove core.platform-mesh.io ApiBindings from them. It leads to the removal of all organizations, accounts, stores and other resources specified in core.platform-mesh.io ApiBinding.To continue with actual migration this issue should be resolved platform-mesh/platform-mesh#43
Migration steps: