Skip to content

feat: Add missing namespace field to Helm templates#167

Merged
cilindrox merged 1 commit intoplexinc:masterfrom
zimmertr:add_ns_to_templates
Mar 9, 2026
Merged

feat: Add missing namespace field to Helm templates#167
cilindrox merged 1 commit intoplexinc:masterfrom
zimmertr:add_ns_to_templates

Conversation

@zimmertr
Copy link
Contributor

@zimmertr zimmertr commented Mar 6, 2026

Should fix this:

Screenshot 2026-03-06 at 2 00 45 PM

When deploying to K8s with Argo CD like this:

namespace: plex-media-server-system

resources:
  - resources/namespace.yml
  - resources/persistentVolume.yml
  - resources/persistentVolumeClaim.yml

commonLabels:
  app.kubernetes.io/name: plex-media-server

helmCharts:
  - includeCRDs: true
    name: plex-media-server
    namespace: plex-media-server-system
    releaseName: plex-media-server
    repo: https://raw.githubusercontent.com/plexinc/pms-docker/gh-pages
    valuesFile: values.yml
    version: 1.4.0

# The Helm Chart doesn't support disabling the dynamic config PersistentVolume.
# I do want one, but I want to statically reference a Mountpoint instead.
patches:
  - patch: |-
      apiVersion: apps/v1
      kind: StatefulSet
      metadata:
        name: plex-media-server
      spec:
        template:
          spec:
            containers:
            - name: plex-media-server-pms
              volumeMounts:
              - name: pms-config
                mountPath: /config
        volumeClaimTemplates:
    target:
      kind: StatefulSet
      name: plex-media-server

@zimmertr zimmertr requested a review from a team as a code owner March 6, 2026 22:00
@zimmertr zimmertr requested review from cookandy and lotooo and removed request for a team March 6, 2026 22:00
@cilindrox cilindrox self-assigned this Mar 9, 2026
Copy link
Member

@cilindrox cilindrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch @zimmertr - we rely on the Application's spec.destination.namespace, so these flew under the radar :/

@cilindrox cilindrox merged commit 582fdee into plexinc:master Mar 9, 2026
2 checks passed
@zimmertr
Copy link
Contributor Author

zimmertr commented Mar 9, 2026

Thank you! Do you know when this will make it into the next release?

@zimmertr zimmertr deleted the add_ns_to_templates branch March 9, 2026 21:42
@cilindrox
Copy link
Member

@zimmertr this should ship as part of v1.5.0 when #168 is merged

@cilindrox
Copy link
Member

v1.5.0 of the chart is out: https://github.com/plexinc/pms-docker/releases/tag/helm-chart-1.5.0

Thanks @zimmertr

@zimmertr
Copy link
Contributor Author

Thank you! That worked, the container deploys successfully with my kustomization now.

@cilindrox
Copy link
Member

@zimmertr feel free to open a PR for the pms-config mount if you'd like - seems like a useful addition :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants