Skip to content

Replace volto style login page with plone style login#132

Open
arybakov05 wants to merge 2 commits into
mainfrom
24-login_page_fix
Open

Replace volto style login page with plone style login#132
arybakov05 wants to merge 2 commits into
mainfrom
24-login_page_fix

Conversation

@arybakov05

Copy link
Copy Markdown
Contributor

Closes #24

new design according to https://www.figma.com/design/YpaRSKjFcFaAkVYnTSVGuz/Volto-UI-%E2%80%93-Quanta?node-id=3480-4187&t=aciKwQrdmZmS1sjk-0:
image

I also made the login fetch the siteLogo, so it can now be swapped with a custom logo:
image

@sneridagh sneridagh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, look at the one comment. I liked also the yellow-ish version!! :)

@pnicolli what do you think!!

@@ -1,13 +1,21 @@
import ploneWhiteSVG from '../../static/plone.svg';
import Plone from '../../static/plone.svg?react';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always have suffixed what that was, as in PloneSVG.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a clear convention so far. I've left out the SVG suffix for icons imported as React components, as has been done in the Toolbar for example. Looking for those imports, I can find at least 3 different variations.
image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm you are correct, the components we used the Icon one... I'd like to come up with one though. What if it's a React component (because we use the SVGO Vite plugin), we use Icon?

/cc @pnicolli

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneridagh Sure, we could open a new PR where we rename all existing icons and add/update the docs so it's clear in the future

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm you are correct, the components we used the Icon one... I'd like to come up with one though. What if it's a React component (because we use the SVGO Vite plugin), we use Icon?

I opened a related issue #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CMSUI] - Authentication (login/logout routes)

2 participants