Add data-style attributes for resolved style fields#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@plone/helperseven when the selected definition has nostyleobject@plone/plateasdata-style-*attributes on editor element propsChanges
packages/helpers/src/styleFields.tsnow records the effective semantic value before checking whether the matching definition contributes CSS, so consumers can still access the resolved value when a style field is value-onlypackages/helpers/src/styleFields.test.tsadds coverage for definitions without astyleobject to lock in the returned{ values, style }contractpackages/plate/components/editor/plugins/style-fields-plugin.tsnow converts resolved style-field values intodata-style-*element props and keeps merging CSS styles when presentpackages/plate/components/editor/plugins/block-width-plugin.test.tsadds assertions for the newdata-style-blockWidthanddata-style-themeattributes so the Plate output contract is explicitpackages/helpers/news/+style-field-values.bugfixdocuments the helpers fixpackages/plate/news/+style-field-data-attrs.featuredocuments the new Plate capabilityTesting
pnpm --filter @plone/helpers test --run src/styleFields.test.tspnpm --filter @plone/plate test --run components/editor/plugins/block-width-plugin.test.tspnpm --filter @plone/plate check:ts