Skip to content

Add origin as query string to requests to plotlyServerURL#7854

Merged
emilykl merged 3 commits into
masterfrom
add-newchart-query-string
Jun 30, 2026
Merged

Add origin as query string to requests to plotlyServerURL#7854
emilykl merged 3 commits into
masterfrom
add-newchart-query-string

Conversation

@marthacryan

@marthacryan marthacryan commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

For secure communication between tabs via postMessage (after clicking the "upload to cloud" button), we need to include the origin of the request as a query string.

Comment thread src/plots/plots.js Outdated

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilykl emilykl added the no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped. label Jun 26, 2026

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, @marthacryan can you update the should open URL in a new tab after clicking confirm button Jasmine test to reflect this change?

Code looks good, so after that it should be good to merge!

@emilykl emilykl merged commit 0d5afad into master Jun 30, 2026
163 of 164 checks passed
@emilykl emilykl deleted the add-newchart-query-string branch June 30, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants