Features/preview and logging#286
Open
EladMichael wants to merge 5 commits into
Open
Conversation
…dded dictionary logging capability, and capability to turn off stdout print with verbosity=0 to declutter when automatic hyperparameter tuning. Added save_weights flag, again for hyperparameter tuning situations, as well as storing run_id for easy access to run parameters downstream. Minimal fix, should not break anything that already uses (or doesn't use) this logger.
…rmation, nodes control their own index mapping as well as their own padding methods and their own preview window sizes, and fixed preview length going stale after nsteps is changed.
…into features/preview_and_logging
…nto features/preview_and_logging
…ts for system preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System (
system.py)Node: newinput_mapparam — per-key temporal window config (past, future, pad_mode, fill)SystemPreview: full redesign — preview config moves from class level to eachNode.input_map; addsstart_iter; supports past + future windows; 4 padding modes_check_unique_names()never actually checked uniqueness; also ran before auto-naming, missing collisions between named and unnamed nodes — both fixedLoggers (
loggers.py)MLFlowLogger:nestedparam for parent/child runs;save_weightsflag;verbosity=0silences stdout; missingstep=arg added to alllog_metriccalls (bug fix); newlog_dictmethodTrainer (
trainer.py)logger.save_weightsbefore saving model artifactsTests (
test_system.py)TestNodeInputMap,TestSystemPreviewGetMappedData(all pad modes + error cases), and 4 forward integration tests forSystemPreviewExamples
Part_3andPart_6migrated to newNode.input_mapAPI; preview horizons decoupled fromnsteps(10 and 5 steps respectively, vs 30 and 20 before)