Allow sorting commitfest entries by "failing since" #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
force-pushed
the
order-patches-by-failing-since
branch
from
9bb9162 to
98016b2
Compare
anarazel
reviewed
Mar 1, 2025
pgcommitfest/commitfest/views.py
Outdated
| failing = True | ||
|
|
||
| if (failing or finished) and bool(branch_in_db.failing_since) is not failing: | ||
| print(branch_in_db.failing_since, failing) |
Member
There was a problem hiding this comment.
I don't know anything about this code - but I wonder if this is intended to be here?
Member
|
The described behaviour makes sense to me! Maybe failing_since could be displayed in the expanded information that's already displayed when hovering? |
JelteF
added a commit
that referenced
this pull request
Mar 1, 2025
JelteF
added a commit
that referenced
this pull request
Mar 1, 2025
JelteF
added a commit
that referenced
this pull request
Mar 1, 2025
JelteF
force-pushed
the
order-patches-by-failing-since
branch
from
943b7fc to
2a276bf
Compare
JelteF
added a commit
that referenced
this pull request
Mar 1, 2025
It got a bit repetitive to keep typing `p.cfbot_results` and it didn't make the templates easy to read.
This adds a new column to the `CfbotBranch` model: `failing_since`. This tracks when a patch first started to fail the CI or started requiring a rebase. This value its primary use is to allow people to sort by the "CI status" column in the patch list. This allows people to quickly see what patches are healthy, which require the author to take action, and which might benefit from a reviewer pinging the author that the patch has been broken for a while. Non-failing builds are sorted on their CI build creation time, so patches that are currently running CI are shown at the top, followed by patches for which CI succeeded most recently. The values of needs_rebase_since and failing_since are also shown on hover and on the patch pages. Fixes #42
We're not showing these first patch sizes on the commitfest page.
JelteF
force-pushed
the
order-patches-by-failing-since
branch
from
2a276bf to
7e174cc
Compare
Collaborator
Author
Done now, and it's now also visible on the patch page. |
This makes it easy to test the new sorting functionality.
JelteF
added a commit
that referenced
this pull request
Mar 17, 2025
It got a bit repetitive to keep typing `p.cfbot_results` and it didn't make the templates easy to read.
JelteF
added a commit
that referenced
this pull request
Mar 17, 2025
This adds a new column to the `CfbotBranch` model: `failing_since`. This tracks when a patch first started to fail the CI or started requiring a rebase. This value its primary use is to allow people to sort by the "CI status" column in the patch list. This allows people to quickly see what patches are healthy, which require the author to take action, and which might benefit from a reviewer pinging the author that the patch has been broken for a while. Non-failing builds are sorted on their CI build creation time, so patches that are currently running CI are shown at the top, followed by patches for which CI succeeded most recently. The values of needs_rebase_since and failing_since are also shown on hover and on the patch pages. Fixes #42
JelteF
added a commit
that referenced
this pull request
Mar 17, 2025
We're not showing these first patch sizes on the commitfest page.
JelteF
added a commit
that referenced
this pull request
Mar 17, 2025
This makes it easy to test the new sorting functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new column to the
CfbotBranchmodel:failing_since. This tracks when a patch first started to fail the CI or started requiring a rebase. This value is not currently shown anywhere, but it is used to sort the patches when clicking the "CI status" column in the patch list. This allows people to quickly see what patches are healthy, which require the author to take action, and which might benefit from a reviewer pinging the author that the patch has been broken for a while. Non-failing builds are sorted on their CI build creation time, so patches that are currently running CI are shown at the top, followed by patches for which CI succeeded most recently.Fixes #42