Add background scaling mode setting#36109
Closed
itsdaliia wants to merge 1 commit into
Closed
Conversation
Adds a user setting to choose between background scaling modes: - Scale to Fill (lazer default): Scales and crops to fill the screen - Scale to Fit (stable default): Scales to fit The setting is located in Settings > Gameplay > Background and updates in real-time by reloading the background when changed. Closes ppy#36035
Contributor
|
did an implementation of this issue yesterday, but was only able to work on pr today, didnt know what else would be interested in i've reviewed your pull request and made some minor changes to mine implementation (#36111), thank you! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36035
Implemented a new
BackgroundScaleModesetting with two options:The setting is accessible via Settings → Gameplay → Background and updates in real-time without requiring to reload the map.