Skip to content

docs(proposals): How? for AWS Bedrock translation (#778) - #783

Open
mkoushni wants to merge 1 commit into
praxis-proxy:mainfrom
mkoushni:proposal/778-bedrock-translation-how
Open

docs(proposals): How? for AWS Bedrock translation (#778)#783
mkoushni wants to merge 1 commit into
praxis-proxy:mainfrom
mkoushni:proposal/778-bedrock-translation-how

Conversation

@mkoushni

Copy link
Copy Markdown
Contributor

Summary

Adds the How? section for #778, one of the four per-provider sub-tasks split out of #762. Builds on the accepted What?/Why? in docs/proposals/00762_api-translation.md.

  • Two new filters (bedrock_translate, bedrock_stream_events) mirroring the existing anthropic_to_openai/anthropic_stream_events structure.
  • Model-in-path handled via the framework's existing pre-read (buffered_request_body) mechanism — no second routing hop needed.
  • Provider identity kept structural (fixed by filter-chain config); model independently allowlisted before path construction.
  • Reuses aws-smithy-eventstream for binary event-stream framing, apis/src/anthropic/to_openai/* for the InvokeModel Anthropic-family body, and the existing credential_inject bearer-token seam for upstream auth (no SigV4 signing needed, per Bedrock API keys).
  • Closes with an explicit acceptance-criteria → design mapping table.

Test plan

  • Maintainer review of design direction (this PR is design-only, no code)
  • Stakeholder review of graduation criteria (fixture manifest, InvokeModel model-family scope, credential rotation strategy)

…y#778)

Adds the implementation design for the AWS Bedrock (Converse +
InvokeModel) sub-task split out of praxis-proxy#762, building on the accepted
What?/Why? in 00762_api-translation.md.

Signed-off-by: mkoushni <mkoushni@redhat.com>
@mkoushni
mkoushni force-pushed the proposal/778-bedrock-translation-how branch from 8456e71 to 2411789 Compare August 19, 2026 14:25
@mkoushni
mkoushni marked this pull request as ready for review August 19, 2026 14:38
@mkoushni
mkoushni requested review from a team and jland-redhat August 19, 2026 14:38
@mkoushni
mkoushni requested a review from shaneutt as a code owner August 19, 2026 14:38
@praxis-bot-app

Copy link
Copy Markdown

Proposal validation failed:

  • docs/proposals/00778_bedrock-translation.md: new proposals must not include the ## How? section in the first PR. Submit What? and Why? first; add How? in a follow-up.
    See proposal process for requirements.

@szedan-rh

Copy link
Copy Markdown
Contributor

LGTM
@aslakknutsen / @alexsnaps - can you please do 2nd eye review?

@alexsnaps alexsnaps left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to find docs/proposals/00762_api-translation.md ?
What am I missing?

Generally tho, I think it's safe to move forward with the implementation of this already

- "InvokeModel model-family scope (Anthropic-shaped body reuse vs. new adapters) reviewed by stakeholders"
- "Bedrock API key rotation/hot-reload strategy for credential_inject reviewed by stakeholders"
stakeholders:
- # TODO: add relevant maintainer/domain-expert handles before merge

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants