test: Correct source map resolution #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
May 25, 2025
Member
Author
|
I should note that I don't have merge rights on this repo so will need someone else to merge this & #501 whenever ready (no rush!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current setup assumes
${output}.mapalways exists, which isn't quite the case for X; the.mjsoutput is a renamed copy of.module.js, includes the original sourcemap comment (pointing at.module.js.map) and all. We therefore don't provide a.mjs.mapas it's not referenced and therefore unused.readFileSyncwould then throw if it attempted to resolve any.mjsfiles for X (as thetest:e2e:gitscript would do)