Add category filter for organization logos on the landing page#842
Add category filter for organization logos on the landing page#842Shaurya8425 wants to merge 7 commits intoprecice:masterfrom
Conversation
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
2fe2eeb to
303e8a8
Compare
|
@Shaurya8425 thanks! |
|
@hanzalahwaheed |
|
pure llm coded poor code pls do as less code changes so it will be helpful for maintainers |
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
303e8a8 to
a24f022
Compare
|
@smackcodernight Thanks for the feedback! I've updated the PR with minimal manual changes — only adding the category field to each entry in logowall.yml and the necessary JS/CSS for the filter. The diff should be much cleaner now. |
|
@Shaurya8425 The feature looks good. One suggestion: when a field is selected, it could move to the top instead of just being hidden. Also, the selected org logos could appear one after another |
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
ce02cfc to
a61ff89
Compare
|
@praaatap Thanks for the suggestions! I’ve pushed the reordering to the top. Kept out stagger animation to stay consistent with the minimal style of the site - happy to add if u think it fits!” |
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
2 times, most recently
from
655a029 to
a36bf90
Compare
- Add filter buttons (All/Academic/Research/Industry) - Add category metadata to logowall.yml - Implement client-side filtering with landing-page.js - Style filter buttons with hover and active states
Shaurya8425
force-pushed
the
fix/landing-page-category-filter
branch
from
a36bf90 to
aec5fdd
Compare
MakisH
added
GSoC
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/introduction-shaurya-yadav/2832/1 |
There was a problem hiding this comment.
Thank you for contributing, @Shaurya8425. This is a nice idea! I thought I could directly fix a few issues, and I pushed a few commits, but this still has issues in narrow screens: the logos overlap, and the button at the bottom has no margin from the left, even though it is still inside a container and section, as other parts of the page.
In the current version, each row just gets fewer elements. Why do you need the new logowall-grid class? If you can reuse the same classes as before, there would be no issue.
Are you still up for following up on this PR?
MakisH
changed the title
6 participants
What
Add category filter buttons (All/Academic/Research/Industry) to the
organization logos section on the landing page.
Why
Makes it easier for visitors to find organizations by type.
Changes