-
Notifications
You must be signed in to change notification settings - Fork 611
added environ credentials support for YDB #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8bda2b8 to
3a4704e
Compare
…t variables for create YDB credentials
|
@mfridman can you consider this enhancement? |
|
Sure, happy to take a look. Seems reasonable. |
| @@ -1,7 +1,518 @@ | |||
| cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
| cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
| cloud.google.com/go v0.38.0/go.mod h1:990N+gfupTy94rShfmMCWGDn0LpTmnzTp2qbd1dvSRU= | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to run go mod tidy, the go.sum doesn't seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go mod tidy clear =/
asmyasnikov@asmyasnikov-ox goose % rm -f go.sum
asmyasnikov@asmyasnikov-ox goose % go mod tidy
asmyasnikov@asmyasnikov-ox goose % git status
Current branch: master
This branch corresponds to "origin/master".
there is nothing to commit (use the "-u" option to show untraceable files)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, now that I'm thinking about it, this is why I didn't want to merge this. This adds an insane amount of entries to the go modules file and it's not something I want to maintain long-term.
In the upcoming /v4 version I'm going to split goose as a library from the CLI code, so they will have different go.mod. I.e., the deps required to build the goose binary are separate from the actual goose provider code.
Curious, is YDB using google cloud apis, or google apis just for the "common types" (e.g., here's a slimmed down version of googleapis https://buf.build/googleapis/googleapis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless this is a bug in Go, I've never seen it add that many entries. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@mfridman CI broken because latest commits in github.com/mfridman/tparse incompatible: |
|
@mfridman Whats a plan for this PR? Wait v4? |
Supported environ credentials for YDB using parameter
use_env_credentialsin connection string.Example with access token credentails:
Example with yandex cloud service account key file credentials: