Skip to content

AMR optimization - #1307

Merged
landinjm merged 6 commits into
prisms-center:masterfrom
landinjm:fix_amr
Aug 18, 2026
Merged

AMR optimization#1307
landinjm merged 6 commits into
prisms-center:masterfrom
landinjm:fix_amr

Conversation

@landinjm

@landinjm landinjm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Moved the refinement manager to a source file.

Still working on some refactoring and cleanup.

Seems like part of the reason for #1082 was the construction of the multigrid hierarchy. We shouldn't do that if we don't need too.

@landinjm

landinjm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Most of it had to do with the FEValues being constructed in the loop. Just like the issue with nucleation.

I'm planning to move these to SystemWide where they can be lazily initialized.

@fractalsbyx FYI

@landinjm

landinjm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

I think we can get away with a single FEValues for scalar and vectors field that works for our modules (AMR, nucleation, integration, grain remapping)

  static dealii::FEValues<dim, dim> &
  vector_fe_values()
  {
    static dealii::FEValues<dim, dim> fe_values(
      mapping,
      fe_systems[1],
      quadrature,
      dealii::UpdateFlags::update_values | dealii::UpdateFlags::update_gradients |
        dealii::UpdateFlags::update_quadrature_points |
        dealii::UpdateFlags::update_JxW_values);
    return fe_values;
  }

@landinjm
landinjm marked this pull request as ready for review August 18, 2026 03:20
@landinjm
landinjm merged commit 6e8d62f into prisms-center:master Aug 18, 2026
3 checks passed
@landinjm
landinjm deleted the fix_amr branch August 18, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant