Skip to content

Conversation

@Irfan762
Copy link

@Irfan762 Irfan762 commented Jan 24, 2026

Fixes #870

Copy link
Collaborator

@coseeian coseeian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks. Let's wait for p5.js Project Lead to weigh in.

&:global(.current) {
text-decoration: none;
a:global(.current) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: prefer adding a new line between L228-229, and remove the empty line at L230.

@Irfan762
Copy link
Author

Fixed Added a new line between L228–L229 and removed the empty line at L230. Thanks!

@Irfan762 Irfan762 closed this Jan 25, 2026
@Irfan762
Copy link
Author

Apologies I closed this PR by mistake while cleaning up the branch history.
I’ll open a fresh PR with a single clean commit addressing the review feedback.
Thanks!

@Irfan762 Irfan762 deleted the fix-link-underline-870 branch January 25, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Link Item] Underline styling is applied to a non-link container instead of the link itself

2 participants