Update translation tracker to handle missing commit data#1108
Merged
perminder-17 merged 1 commit intoprocessing:mainfrom Jan 27, 2026
Merged
Update translation tracker to handle missing commit data#1108perminder-17 merged 1 commit intoprocessing:mainfrom
perminder-17 merged 1 commit intoprocessing:mainfrom
Conversation
Member
|
Hi @perminder-17 great catch! The root cause when a file had all translations missing (none existed), the loop would: I have raised #1118 for the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I merged a PR #1105 the CI test were failing, saying that no englishCommit data is available.
So, in this PR I just added a guard, when the data is null, it shouldn't crash. I haven't gone till the root cause of the problem, @Divyansh013 do you have any idea on this? Since I saw the latest commit to this file was from you. Thanks for the help.