fix(SelfSubjectReview): authorization for ns#919
fix(SelfSubjectReview): authorization for ns#919oliverbaehler merged 3 commits intoprojectcapsule:mainfrom
Conversation
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
|
Any update on this ? It looks 100% implemented |
|
Everything is working in k9s as far as I know it's just waiting for a review |
prometherion
left a comment
prometherion
left a comment
There was a problem hiding this comment.
LGTM, I think this will unlock also supports for Headlamp.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| scheme := runtime.NewScheme() | ||
| protoEncoder := protobuf.NewSerializer(scheme, scheme) | ||
| corev1.AddToScheme(scheme) |
Check warning
Code scanning / gosec
Errors unhandled Warning
| scheme := runtime.NewScheme() | ||
| protoEncoder := protobuf.NewSerializer(scheme, scheme) | ||
| corev1.AddToScheme(scheme) | ||
| authorizationv1.AddToScheme(scheme) |
Check warning
Code scanning / gosec
Errors unhandled Warning
| } | ||
| } | ||
| writer.WriteHeader(w.Result().StatusCode) | ||
| writer.Write(body) |
Check warning
Code scanning / gosec
Errors unhandled Warning
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
|
This pull request has been marked as stale because it has been inactive for more than 30 days. Please update this pull request or it will be automatically closed in 7 days. |
5 participants
Fixes #1666 by mutating the selfsubjectaccessreviews and selfsubjectrulesreviews for the namespaces