Add opt-in Vec TTL via MetricVec and TTLRegistry#1989
Open
jpinsonneau wants to merge 1 commit into
Open
Conversation
jpinsonneau
force-pushed
the
ttl-registry
branch
from
9ca0d4c to
530bbbe
Compare
Introduce NewMetricVecWithTTL and per-child lastAccessed tracking so stale label sets can be omitted from Collect and removed with CleanupExpired. Store vec children as pointers to satisfy atomic copying rules. Keep default NewCounterVec/NewGaugeVec/NewHistogramVec on NewMetricVec without TTL for backwards compatibility. Opt-in TTLRegistry wraps a dedicated Registry, exposes New*Vec constructors with a fixed ttl, and runs CleanupExpired before each Gather. Relates to prometheus#1983 Signed-off-by: Julien Pinsonneau <jpinsonn@redhat.com> Made-with: Cursor
jpinsonneau
force-pushed
the
ttl-registry
branch
from
530bbbe to
384151c
Compare
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce NewMetricVecWithTTL and per-child lastAccessed tracking so
stale label sets can be omitted from Collect and removed with
CleanupExpired. Store vec children as pointers to satisfy atomic
copying rules.
Keep default NewCounterVec/NewGaugeVec/NewHistogramVec on NewMetricVec
without TTL for backwards compatibility. Opt-in TTLRegistry wraps a
dedicated Registry, exposes New*Vec constructors with a fixed ttl, and
runs CleanupExpired before each Gather.
Relates to #1983
Signed-off-by: Julien Pinsonneau jpinsonn@redhat.com
Made-with: Cursor