nvme: Fix namespace parsing#821
Open
goll wants to merge 1 commit into
Open
Conversation
Signed-off-by: goll <goll@users.noreply.github.com>
Author
|
@discordianfish @SuperQ since you gentlemen handled #765 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the namespace parsing bug introduced by #765 as the regex on L30 in class_nvme.go explicitly looks for nvme0c0n0.
Standard nvme devices will not have the c0 identifier, from what I gather that is only applicable in some multipath setups, it will just be nvme0n1 for example.
Noticed this following node_exporter upgrade that promised nvme metrics which were missing on all updated systems.