Add fallback config paths for typegen CLI#295
Conversation
🦋 Changeset detectedLatest commit: 04a3edf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@proofkit/better-auth
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
📝 WalkthroughWalkthroughThe typegen CLI now searches additional default config names and file extensions, and ChangesTypegen config resolution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.changeset/quiet-walls-move.md (1)
5-5: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueChangeset note understates the change.
The release note only mentions
.json, but the feature also resolves the.jsoncvariants (proofkit.config.jsonc,adt.config.jsonc). Consider clarifying so the changelog reflects both extensions.📝 Suggested wording
-Find `proofkit.config.json` and `adt.config.json` when resolving typegen CLI config. +Find `proofkit.config.{jsonc,json}` and `adt.config.{jsonc,json}` when resolving typegen CLI config.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.changeset/quiet-walls-move.md at line 5, The changeset note is incomplete because it only mentions the .json config files; update the wording to also include the .jsonc variants resolved by the typegen CLI config logic, and reference the proofkit.config/adt.config note so the changelog accurately reflects both extensions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.changeset/quiet-walls-move.md:
- Line 5: The changeset note is incomplete because it only mentions the .json
config files; update the wording to also include the .jsonc variants resolved by
the typegen CLI config logic, and reference the proofkit.config/adt.config note
so the changelog accurately reflects both extensions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0b9ec4d4-5218-41fb-98b6-d7e48bdf4354
📒 Files selected for processing (3)
.changeset/quiet-walls-move.mdpackages/typegen/src/cli.tspackages/typegen/tests/cli-config.test.ts

Summary
proofkit.config.*andadt.config.*alongside existing typegen config namesjsoncpreferred overjsonfor each config nameTesting
Summary by CodeRabbit
New Features
proofkit.configandadt.config, with support for both.jsoncand.jsonformats.Tests