Skip to content

fix: keep the typed text when typing over a fully selected code block #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocavue merged 2 commits into from
Jul 24, 2026
Merged

fix: keep the typed text when typing over a fully selected code block #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37e86d8
fix: keep the typed text when typing over a fully selected code block
ocavue Jul 24, 2026
76afe5b
chore: trigger ci
ocavue Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/react/src/components/code-block-view.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import '../testing/index.ts'

import { readClipboard } from '@meowdown/vitest/clipboard'
import { isFirefox } from '@meowdown/vitest/helpers'
import { TextSelection } from '@prosekit/pm/state'
import type { EditorView } from '@prosekit/pm/view'
import { createRef } from 'react'
Expand Down Expand Up @@ -297,10 +296,7 @@ describe('typing over code block selections', () => {
})
})

it.skipIf(
// Firefox edits the text node in place and is not affected.
isFirefox(),
).fails('updates the markdown when typing over the full code text', async () => {
it('updates the markdown when typing over the full code text', async () => {
const { ref, view, codeStart, codeEnd } = await setupHighlightedCodeBlock()
selectCodeRange(view, codeStart, codeEnd)
await userEvent.keyboard('X')
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/code-block-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ export function CodeBlockView(props: ReactNodeViewProps): ReactElement {

return (
<div className={styles.Root} data-preview={previewOnly || undefined}>
<pre ref={contentRef} data-language={language}></pre>
{
/* Skip rendering the toolbar during dragging to improve the performance of rendering the drag preview image in Safari */
selected ? null : (
<CodeBlockToolbar code={code} language={language} setLanguage={setLanguage} />
)
}
<pre ref={contentRef} data-language={language}></pre>
{showMathPreview && (
<MathRender
katex={katex}
Expand Down
22 changes: 13 additions & 9 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ minimumReleaseAgeExclude:
- '@ocavue/eslint-config'
- '@prosekit/*'
- '@aria-ui/*'
- '@prosemirror-adapter/*'
- prosemirror-view

allowBuilds:
Expand All @@ -31,3 +32,7 @@ allowBuilds:
# '@prosekit/core': https://pkg.pr.new/@prosekit/core@7b1d474b13916ed1a34d54a2c9339a95d0c9be6f
# '@prosekit/extensions': https://pkg.pr.new/@prosekit/extensions@7b1d474b13916ed1a34d54a2c9339a95d0c9be6f
# '@prosekit/web': https://pkg.pr.new/@prosekit/web@7b1d474b13916ed1a34d54a2c9339a95d0c9be6f

overrides:
'@prosemirror-adapter/core': '0.5.5'
'@prosemirror-adapter/react': '0.5.5'
Loading