txtpbfmt: Add support for formatting repeated primitive fields as lists.
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_834277184
branch
2 times, most recently
from
4e44ace to
b914c80
Compare
…ists. When this option is used, repeated primitive fields are printed using a more conscice list syntax: ```textproto repeated_field: 1 repeated_field: 2 repeated_field: 3 ``` vs ```textproto repeated_field: [1, 2, 3] ``` This syntax is part of the go/textformat-spec (screen/4cDavcUGvdjyWwN), thus it's supported by all parsers. Furthermore, some proto implementations (like [C++](http://google3/third_party/protobuf/text_format.h;l=407;rcl=828248838) and [Java](http://google3/third_party/java_src/protobuf/current/java/com/google/protobuf/TextFormat.java;l=385;rcl=815831657)) allow using it when printing text-proto. This CL is a no-op if the config option isn't used. PiperOrigin-RevId: 836120469
copybara-service
bot
force-pushed
the
test_834277184
branch
from
b914c80 to
fcb97cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txtpbfmt: Add support for formatting repeated primitive fields as lists.When this option is used, repeated primitive fields are printed using a more conscice list syntax:
vs
repeated_field: [1, 2, 3]This syntax is part of the go/textformat-spec (screen/4cDavcUGvdjyWwN), thus it's supported by all parsers. Furthermore, some proto implementations (like C++ and Java) allow using it when printing text-proto.
This CL is a no-op if the config option isn't used.