Fix deepcopy crash when uploading file with labels#356
Merged
Conversation
dkliban
force-pushed
the
fix/upload-deepcopy
branch
from
6bdaca1 to
fad8a74
Compare
dkliban
force-pushed
the
fix/upload-deepcopy
branch
from
61fec00 to
ce49b29
Compare
dkliban
force-pushed
the
fix/upload-deepcopy
branch
3 times, most recently
from
83ac3bb to
c152988
Compare
QueryDict.copy() fails with TypeError when the request contains uploaded files with hashers (_hashlib.HASH objects cannot be pickled). Use _mutable flag instead to modify pulp_labels in place. Also adds labels to the file upload test to cover this code path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dkliban
force-pushed
the
fix/upload-deepcopy
branch
from
c152988 to
64ef486
Compare
Backport to 0.16: 💚 backport PR created✅ Backport PR branch: Backported as #357 🤖 @patchback |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: cannot pickle '_hashlib.HASH' objectwhen uploading a file withpulp_labelsvia the synchronous upload endpointQueryDict.copy()does a deep copy which fails on uploaded files with hashers — use_mutableflag to modifypulp_labelsin place insteadpulp_labelsto the file upload test to cover this code pathTest plan
test_upload_maven_artifact_with_file— now uploads withpulp_labels={"type": "jar", "source": "test"}and verifies labels are stored🤖 Generated with Claude Code