refactor: consolidate unsupported ISLE check into has_unknown_instructions#63
Closed
refactor: consolidate unsupported ISLE check into has_unknown_instructions#63
Conversation
…own_instructions After PR #53, all standard WASM instructions are supported by the ISLE pipeline. has_unsupported_isle_instructions only checked for Unknown opcodes — identical to has_unknown_instructions but with recursive block traversal. Consolidate into a single recursive has_unknown_instructions and remove has_unsupported_isle_instructions (15 call sites simplified). Closes #60 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by #64 which includes this change plus control-flow-aware env clearing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_unsupported_isle_instructionsandhas_unsupported_isle_instructions_in_block(now redundant after PR feat: complete ISLE pipeline coverage — all standard WASM instructions #53 wired all standard WASM instructions into ISLE)has_unknown_instructionsrecursive (checks nested blocks)has_unknown_instructions(func) || has_unsupported_isle_instructions(func)to justhas_unknown_instructions(func)Closes #60
Test plan
🤖 Generated with Claude Code