fix: split Phase R own<T> result transfer around post_return#57
Merged
Conversation
Previously Phase R (resource.rep then resource.new) ran as a single block before post_return. This overwrote the result locals with converted handles, so post_return received the caller's new handles instead of the callee's originals — dropping the wrong handles. Split into two phases with scratch locals: 1. Phase R-rep: resource.rep(handle) → rep (before post_return) 2. Post_return with original handles (drops callee handles) 3. Phase R-new: resource.new(rep) → new handle (after post_return) This ensures post_return drops the correct callee handles, and the caller gets fresh handles minted from the extracted representations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the own result transfer (Phase R) into two sub-phases with scratch locals,
interleaving post_return correctly:
resource.rep(handle) → rep(while callee handles are still alive)resource.new(rep) → new_handle(mints fresh handles from reps)Previously Phase R ran as a single block before post_return, overwriting result locals
with converted handles. Post_return then received the caller's new handles instead of
the callee's originals — dropping the wrong ones.
Test plan
cargo +stable clippy --all-targets -- -D warningsclean🤖 Generated with Claude Code