chore: update allowed hosts for Docker internal network - #1270
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
=======================================
Coverage 74.60% 74.60%
=======================================
Files 84 84
Lines 3186 3186
=======================================
Hits 2377 2377
Misses 809 809 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Lee-W
approved these changes
Jul 26, 2026
| from .base import * # noqa | ||
| from .base import BASE_DIR, STATICFILES_DIRS, TEMPLATES | ||
| from .base import ( | ||
| ALLOWED_HOSTS as BASE_ALLOWED_HOSTS, |
Member
There was a problem hiding this comment.
Would like to check why do we need this alias
Member
Author
There was a problem hiding this comment.
I just used the alias to make it clear that we’re extending the value from the base settings before overriding it here. If you think it’s unnecessary, I can keep the code as follows:
ALLOWED_HOSTS = [*ALLOWED_HOSTS, CONFERENCE_DEFAULT_SLUG]
mattwang44
approved these changes
Jul 26, 2026
Co-authored-by: W. H. Wang <mattwang44@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
xin the box that appliesDescription
Allow frontend web to request via Docker network host
http://pycontw-2026[:XXXX]/Steps to Test This Pull Request
Request
http://pycontw-2026[:XXXX]/in the same docker network.Expected behavior
Request success.