Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
Member
Author
|
After confirming with Ivan Sinkarenko I have pinned |
jgray-19
reviewed
Mar 12, 2026
jgray-19
approved these changes
Mar 12, 2026
Member
Author
|
Merging as the low coverage is of no impact on this package: almost everything here is CERN-network specific and can't run on this CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pyjapcpackage, which is part of the[cern]optional dependencies, has reached its end-of-life.I have pinned the dependency on
python_version < 3.14and added a warning straight away inbrst_logger.pyto provide information on this. Realistically, the BRST logger script has not been used in the past 5 years so I don't expect much disruption.This would be a patch release.
Note: I have pinned
< 3.14for now but I'm waiting on Phil Elson or others to clarify which Python version exactly is the last supported one, officially. I might change this pin again.With regards to the
Acc-Pydistributions, considering the last one was3.11-based (supported) and the new one is3.14-based (unsupported) this still works for now.