Skip to content

fix(api): drop dead TEMPORAL_API_HOST/PORT settings #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chouffe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): drop dead TEMPORAL_API_HOST/PORT settings #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ will fail at the `COPY` step without it.)

Configuration via env vars (prefix `TEMPORAL_API_`): `MODEL_PATH`, `DEVICE`,
`CALIBRATOR_THRESHOLD`, `TOKEN`, `FRAME_SOURCE`, `FRAMES_ROOT`, `S3_BUCKET`,
`S3_REGION`, `S3_ENDPOINT_URL` (empty = real AWS; set for OVH or MinIO),
`HOST`, `PORT`. AWS/OVH/MinIO credentials come from the standard boto3 chain
`S3_REGION`, `S3_ENDPOINT_URL` (empty = real AWS; set for OVH or MinIO).
AWS/OVH/MinIO credentials come from the standard boto3 chain
(env vars / IAM role). `S3_BUCKET` is an optional default; a request may
override it per call with its `bucket` field (needed for alert-api stacks
whose per-org bucket names are not known ahead of time). A request with
Expand Down
3 changes: 0 additions & 3 deletions api/src/temporal_model/api/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ class Settings(BaseSettings):
# probe arbitrary server paths.
frames_root: str = ""

host: str = "0.0.0.0"
port: int = 8000

@model_validator(mode="after")
def _require_frames_root_for_local(self) -> "Settings":
# A local-default server without a root would 400 on every request;
Expand Down
1 change: 0 additions & 1 deletion api/tests/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ def test_defaults():
assert s.s3_bucket == ""
assert s.s3_region is None
assert s.s3_endpoint_url is None
assert s.port == 8000


def test_env_override(monkeypatch):
Expand Down
Loading