feat: switch to anidb as provider for v5

[71zenith]

Pull Request Template

Type of change

• Bug fix
• Feature
• Documentation update

Description

ramble here

Checklist

• any anime playing
• bumped version

---

• next, prev, replay and select work
• -c history and continue work
• -d downloads work
• -e (select episode) aka -r (range selection) works
• -S select index works
• -q quality works
• -s syncplay works
• -v vlc works
• --dub and regular (sub) mode both work
• --nextep-countdown countdown to next ep works

---

• -h help info is up to date
• Readme is up to date
• Man page is up to date

Additional Testcases

(these don't block a merge)

• --skip ani-skip works
• --skip-title ani-skip title argument works
• --no-detach no detach works
• --exit-after-play auto exit after playing works
• all providers return links (not necessarily on a single anime, use debug mode to confirm)

Particular anime

• The safe bet: One Piece
• Episode 0: Saenai Heroine no Sodatekata ♭
• Unicode: Saenai Heroine no Sodatekata ♭
• Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
• The examples of the help text

[candrapersada]

why Invalid/No Episode Selection for anime that use seasons if you use -e 2

[71zenith]

Because anidb lists episodes as if theyre part of a single continuing anime. So episode 1 of season 2 is branded as episode 14(if there were 13 episodes in the season 1). It is definitely an annoyance.

[vorlie]

and for example attack on titan, episode numbers in the videos itself do not follow S00E00 pattern, so s2 can have ep26 which is s2ep1, s3 ep38 which is s3ep1 etc.

source: crunchyroll

[candrapersada]

then how to choose episode 3 to 5 from season 3
-e 3-5 or -e 40-43

[port19x]

Because anidb lists episodes as if theyre part of a single continuing anime. So episode 1 of season 2 is branded as episode 14(if there were 13 episodes in the season 1). It is definitely an annoyance.

imo this is fair numbering, wouldn't bother me :)

[71zenith]

I don't like it personally. Besides it messes up ani-skip.

[mbpowers]

If we are changing this much should we try and get playlist functionality into v5? regarding #1755

[candrapersada]

why -e 26-28,31-33 skip episode 29 and 30 not work?

[71zenith]

-e 26-28,31-33 is not even officially supported syntax so it is undefined behaviour. We only support -e 26-28 or -e "26 28" or special syntax for last episode -e "26 -1"/ 26--1

[candrapersada]

how to use skip episode from fzf?

[port19x]

potential for dependency checking improvement:

dep_ch "$menu_program" runs even for fully non-interactive invocations (-S 1 -e 1 query), where no menu is ever opened.

[Lost-Shadow99]

I might be a little late to this but I installed the v5 branch and am getting the 0x error. I remember someone mentioned how to switch the route if you will from bash to another to get rid of the error. Can someone show me how to do that and than what to do next if another error pops up? I use the Linux mint terminal

[mbpowers]

@Lost-Shadow99 You should head to the discord or matrix for individual support instead of in this PR. I think you likely are not actually using v5. Also replacing #!/bin/sh with #!/bin/bash never actually solved the underlying Illegal Number issue, just surfaced the underlying error more clearly.

[Lost-Shadow99]

@mbpowers Gotcha will do.

[port19x]

hacking.md is out of date and should be updated post merge

[port19x]

Final Review (does any anime play):

• Mac OS
• iOS
• Windows (tested by @vorlie)
• Linux (tested by mbpowers on discord)
• Android (tested by @71zenith)