-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Docs/monorepo python versions #20375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lamia-bel
wants to merge
13
commits into
python:master
Choose a base branch
from
ines-bg:docs/monorepo-python-versions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−1
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9138d86
test_scope_behavior.py
Sabine22-alt 7b2d6df
modification fichier scope.py
lamia-bel 2b1bba2
ajout du test unitaire issue_scope.test
ines-bg 8f6c3c2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 449df98
modification2 fichier scope.py
lamia-bel e527a5e
Merge pull request #2 from ines-bg/sabine
ines-bg 1ebe142
Merge pull request #3 from ines-bg/ines
ines-bg b6d168a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 14a4ff5
Merge pull request #4 from ines-bg/lamia
ines-bg 51c2d18
Merge branch 'python:master' into master
ines-bg ddbe761
Add note explaining that mypy only supports one global python_version…
lamia-bel 51d08a0
solutions proposés pour differentes versions python
lamia-bel f4acafe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This (and other changes) don't seem related? Did you accidentally include them on this branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from mypy.nodes import FuncDef, SymbolTable, TypeInfo | ||
| from mypy.scope import Scope | ||
|
|
||
|
|
||
| def test_scope_module_and_function_behavior() -> None: | ||
| scope = Scope() | ||
| with scope.module_scope("mod1"): | ||
| assert scope.current_module_id() == "mod1" | ||
| # simulate function | ||
| fake_func = FuncDef("f", None, None, None, None) | ||
| with scope.function_scope(fake_func): | ||
| assert "f" in scope.current_full_target() | ||
| # simulate class inside function | ||
| fake_class = TypeInfo(SymbolTable(), "C", None) | ||
| with scope.class_scope(fake_class): | ||
| assert "C" in scope.current_full_target() | ||
| # leaving function restores module | ||
| assert scope.current_full_target() == "mod1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| [case testScopeOptionalIntResolution] | ||
| from typing import Optional | ||
|
|
||
| x: Optional[int] = None | ||
| y: Optional[int] = None | ||
|
|
||
| def f() -> None: | ||
| x = 1 | ||
| y = 1 | ||
| class C: | ||
| reveal_type(x) # should be int | ||
| reveal_type(y) # should be Optional[int] | ||
| x = 2 | ||
|
|
||
| [out] | ||
| note: Revealed type is "builtins.int" | ||
| note: Revealed type is "Union[builtins.int, None]" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this part is necessary.