Shapely: Add Any typing to kwargs arguments#15858
Closed
jack-volantautonomy wants to merge 2 commits into
Closed
Conversation
Collaborator
|
I'm sorry, but it's typeshed policy not to use |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to add a form of typing to the
kwargsarguments as usage of these methods results in lots ofreportUnknownMemberTypechecks being flagged in codebases with check enabled.Anytyping doesn't provide any extra type safety, but is in no way a downgrade from having no typing at all.In future it would be nice to type these better or if
numpy.typingincludes a typing for this kwargs argument forufunc.kwargs, but I cannot see anything at current. At this moment, this seems like the most logical and simple fix for this exact issue.