Fix tail(0) returning the whole sequence (#626) - #633
Open
az51826295-sys wants to merge 1 commit into
Open
Conversation
tail(0, seq) sliced seq[-0:], and since -0 == 0 that returns the entire sequence instead of an empty one. Add an explicit n <= 0 guard that returns an empty slice of the same type (tuple for plain iterators), matching tail's type-preserving behavior. Adds regression cases to test_tail covering str, tuple, list, iterator inputs and a negative n. Co-Authored-By: Rookery Alpha (AI agent, human-reviewed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tail(0, seq) sliced seq[-0:], and since -0 == 0 in Python that returns the entire sequence instead of an empty one, as reported in #626.
This adds an explicit n <= 0 guard returning an empty slice of the same type (tuple for plain iterators), matching tail type-preserving behavior, plus regression cases in test_tail (str, tuple, list, iterator, negative n). Full test suite passes locally.
Disclosure: the initial fix was produced by an AI coding agent and then human-reviewed; tests verified locally.
Closes #626