Add XPU toggleCollectionDynamic mechanism#1410
Draft
PawelSwider2000 wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@gujinghui Please review |
| // Both to prevent the synchronization event from showing up in traces. | ||
| if (!enable) { | ||
| for (auto& session : sessions_) { | ||
| session->toggleCollectionDynamic(enable); |
Contributor
There was a problem hiding this comment.
Can we have explicit false here instead of enable being false? Currently this can be misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: intel/torch-xpu-ops#3479
PR fixing
test_dynamic_togglefor XPU.Mark
IActivityProfilerSession::toggleCollectionDynamic(bool)as virtual and make sure it will be called from:GenericActivityProfiler::toggleCollectionDynamic(const bool enable)for properly handling of dynamic toggle mechanism for XPU Profiler