Update test-plans script to mitigate STREAM_CLOSED errors preventing successful results#30
Merged
Merged
Conversation
The results of the test needs to be separtely printed without logger info for the framework to parse it.
# Conflicts: # test-plans/transport_interop/test_plans_ping.cpp
turuslan
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous test-plans script was failing for 2 reasons: -
ping->start()was also running in dialer which pre-occupied a stream to the listener on connect which made the direct ping fail.To solve this issues: -
ping->start()was moved to listener only logic.Certain improvements: -
These changes were succesful in producing results with all non-failing interop tests and the framework was also able to parse the results successfully.
NOTE:
Warning ListenerManager can not negotiate protocols, STREAM_CLOSEDfor certain tests which is likely due to the fact that either dialer closed the stream while still being actively checking the loop for connections or listener closed the stream as soon as it sends back a ping response. Both in which case is ignorable.