Skip to content

Add Shikra (QCM2390) display support for CQS and CQM targets#679

Merged
sgaud-quic merged 4 commits into
qualcomm-linux:qcom-6.18.yfrom
naala-qcom:dt-changes
Jun 19, 2026
Merged

Add Shikra (QCM2390) display support for CQS and CQM targets#679
sgaud-quic merged 4 commits into
qualcomm-linux:qcom-6.18.yfrom
naala-qcom:dt-changes

Conversation

@naala-qcom

@naala-qcom naala-qcom commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

@naala-qcom naala-qcom requested review from a team, Komal-Bajaj, aiquny and quic-kaushalk June 9, 2026 17:01
@qlijarvis

qlijarvis commented Jun 9, 2026

Copy link
Copy Markdown

PR #679 — validate-patch

PR: #679

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present:

    • Patch 01: No — vendor revert, no lore link expected
    • Patches 02-20: Yes — FROMLIST with lore.kernel.org links
    • Patches 21-28: No — new patches not yet posted upstream

  2. Lore link matches PR commits:

    • Patches 02-20: Cannot verify — lore links point to future dates (2026-06-04/05)
    • Other patches: N/A

  3. Upstream patch status:

    • Patches 02-20: Cannot determine — future-dated links
    • Patches 21-28: Not posted upstream yet (patches 23-24 have maintainer reviews suggesting they may be in review)

  4. PR present in qcom-next: Not checked — would require access to qcom-next branch

Recommendation: Before merging, remove all Change-Id tags from patches 2-14, fix the typo in patch 01, and add EOF newline to patch 22. The FROMLIST patches appear to be from an upcoming upstream submission series.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #679 - Shikra Display Subsystem Support (28 patches)
Upstream commit: Multiple lore.kernel.org links (FROMLIST patches 2-20) + vendor patches (1, 21-28)
Verdict: ⚠️ PARTIAL

Summary by Patch Type

Patch 01: Vendor revert (no lore link expected)
Patches 02-20: FROMLIST patches with lore links
Patches 21-28: New patches without lore links (not yet posted upstream)

Commit Message Issues

Patch Issue Severity
01 Typo: "code chages" → "code changes" ⚠️ Minor
02-14 Change-Id tags present (Gerrit artifact) ❌ Must remove
02-20 FROMLIST patches - lore links point to future dates (2026-06-04/05) ⚠️ Cannot verify

Authorship & Tags

Check Status Note
Author preserved ✅ Imran Shaik, Nabige Aala, Arpit Saini
Signed-off-by present ✅ All patches have SOB
Reviewed-by tags ✅ Patches 23-24 have upstream reviews (Dmitry Baryshkov, Krzysztof Kozlowski, Loic Poulain)
Change-Id tags ❌ Present in patches 2-14 (must be removed before upstream submission)

Patch Categories

Category 1: Vendor Revert (Patch 01)

  • Subject: "clk: qcom: Revert older series Shikra GPUCC/DISPCC changes"
  • Status: ⚠️ Typo in commit body ("chages")
  • Lore link: N/A (vendor-only revert)

Category 2: FROMLIST Clock Patches (02-20)

  • All have Link: tags pointing to lore.kernel.org
  • Series IDs: 20260604-shikra-dispcc-gpucc-v4-* and 20260605-shikra-*
  • Status: ⚠️ Cannot verify (future dates), ❌ Change-Id tags must be removed
  • Patches cover: gcc-qcm2290, dispcc, gpucc, audiocorecc, DT bindings

Category 3: New Display Patches (21-28)

  • No lore links (not yet posted upstream)
  • Patches:
    • 21: dt-bindings: ILI7807S panel controller
    • 22: drm/panel: ILI7807S driver
    • 23: dt-bindings: Shikra MDSS (has Reviewed-by tags)
    • 24: soc: qcom: ubwc config (has Reviewed-by tag)
    • 25-28: arm64: dts additions and defconfig

Issues

Critical (Must Fix):

  1. Change-Id tags in patches 2-14 - These are Gerrit artifacts and must be removed before upstream submission. They are not acceptable in kernel patches.

Minor (Should Fix):
2. Typo in patch 01 - "code chages" should be "code changes"
3. Missing newline at EOF - Patch 22 (panel driver) ends without newline: MODULE_LICENSE("GPL");\ No newline at end of file

Cannot Verify:
4. FROMLIST patches reference future dates - Lore links point to 2026-06-04 and 2026-06-05, which don't exist yet. Cannot verify diff faithfulness or upstream acceptance status.

Diff Spot Checks

File Status Notes
drivers/clk/qcom/gcc-qcm2290.c ⚠️ Cannot verify against lore (future date)
drivers/gpu/drm/panel/panel-ilitek-ili7807s.c ⚠️ Missing EOF newline
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Looks reasonable for new SoC support
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ✅ Board-specific display enablement

Verdict

Patches 02-14: ❌ MUST FIX - Remove Change-Id tags before merging. These are Gerrit artifacts not acceptable in upstream kernel patches.

Patch 01: ⚠️ SHOULD FIX - Fix typo "chages" → "changes"

Patch 22: ⚠️ SHOULD FIX - Add newline at end of file

Patches 21-28: ✅ ACCEPTABLE - New patches not yet posted upstream. Patches 23-24 already have upstream maintainer reviews.

Overall: The PR mixes vendor reverts, FROMLIST patches, and new patches. The FROMLIST patches contain Change-Id tags that must be removed. Cannot verify faithfulness to upstream due to future-dated lore links.

Final Summary

  1. Lore link present:

    • Patch 01: No — vendor revert, no lore link expected
    • Patches 02-20: Yes — FROMLIST with lore.kernel.org links
    • Patches 21-28: No — new patches not yet posted upstream

  2. Lore link matches PR commits:

    • Patches 02-20: Cannot verify — lore links point to future dates (2026-06-04/05)
    • Other patches: N/A

  3. Upstream patch status:

    • Patches 02-20: Cannot determine — future-dated links
    • Patches 21-28: Not posted upstream yet (patches 23-24 have maintainer reviews suggesting they may be in review)

  4. PR present in qcom-next: Not checked — would require access to qcom-next branch

Recommendation: Before merging, remove all Change-Id tags from patches 2-14, fix the typo in patch 01, and add EOF newline to patch 22. The FROMLIST patches appear to be from an upcoming upstream submission series.

@qlijarvis

qlijarvis commented Jun 9, 2026

Copy link
Copy Markdown

PR #679 — checker-log-analyzer

PR: #679
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27222640163

Checker Result Summary
Checker Result Summary
checkpatch ❌ 13 commits with Gerrit Change-Id; 1 commit with indentation errors (60 lines)
dt-binding-check ✅ Passed
dtb-check ❌ DTS syntax error (missing label) + schema validation failures
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 9 commits missing required prefix; 2 commits differ from upstream Link
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ 20 FROMLIST commits present (expected for qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #679 - Shikra GPUCC/DISPCC and Display Subsystem Support (28 commits)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27222640163

Checker Result Summary
checkpatch ❌ 13 commits with Gerrit Change-Id; 1 commit with indentation errors (60 lines)
dt-binding-check ✅ Passed
dtb-check ❌ DTS syntax error (missing label) + schema validation failures
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 9 commits missing required prefix; 2 commits differ from upstream Link
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ 20 FROMLIST commits present (expected for qcom-next)

❌ checkpatch

Root cause: 13 commits contain Gerrit Change-Id: trailers that must be removed before upstream submission, and 1 commit has 60 lines with space indentation instead of tabs.

Failure details:

ERROR: Remove Gerrit Change-Id's before submitting upstream

Affected commits (13):
- 71ebdda8cca7 FROMLIST: clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe
- cd0a8f02fa5d FROMLIST: dt-bindings: clock: qcom,qcm2290-dispcc: Add DSI1 PHY and sleep clocks
- 6e1782a40219 FROMLIST: dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller
- 0f47b7f3b4f1 FROMLIST: dt-bindings: clock: qcom: Add Qualcomm Shikra GPU clock controller
- b473f6a29cff FROMLIST: clk: qcom: dispcc-qcm2290: Move to the latest common qcom_cc_probe() model
- 4ff200a789c3 FROMLIST: clk: qcom: dispcc-qcm2290: Switch to DT index based clk lookup
- 4ebc9d18b40e FROMLIST: clk: qcom: dispcc-qcm2290: Update GDSC *wait_val values and flags
- 85c0d8c5ee39 FROMLIST: clk: qcom: gpucc-qcm2290: Move to the latest common qcom_cc_probe() model
- ec6ae89ebd72 FROMLIST: clk: qcom: gpucc-qcm2290: Park RCG's clk source at XO during disable
- (4 more commits)

ERROR: code indent should use tabs where possible (60 occurrences)

Affected commit:
- 33051f09593b dt-bindings: display: msm: qcm2290: Add Shikra MDSS

Fix:

  1. Remove all Change-Id: lines from commit messages:

    git rebase -i HEAD~28
# Mark affected commits for 'edit'
# For each commit:
git commit --amend
# Delete the "Change-Id: I..." line from the commit message
git rebase --continue

  2. Fix indentation in dt-bindings: display: msm: qcm2290: Add Shikra MDSS:

    git show 33051f09593b > /tmp/patch.diff
# Identify the file with space indentation (likely a YAML binding)
# Replace leading spaces with tabs in the affected sections
# Amend the commit with corrected indentation

Reproduce locally:

git fetch origin pull/679/head:pr679
git checkout pr679
./scripts/checkpatch.pl --git HEAD~28..HEAD

❌ dtb-check

Root cause: DTS file arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:136 references undefined label usb_qmpphy_out, causing a fatal DTC syntax error. Additionally, multiple schema validation failures exist for panel and MDSS nodes.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:136.1-16 Label or path usb_qmpphy_out not found
FATAL ERROR: Syntax error parsing input tree
make[4]: *** [../scripts/Makefile.dtbs:132: arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb] Error 1

Schema validation failures:
1. shikra-cqm-evk.dtb: display-subsystem@5e00000 (qcom,shikra-mdss): 
   iommus: [[31, 1056, 2]] is too short

2. shikra-cqm-evk.dtb: panel@0 (dlc,dlc0697):
   - 'bias-supply', 'enable-gpios', 'vddio-supply' do not match any of the regexes
   - compatible: ['dlc,dlc0697'] is too short (needs fallback compatible)
   - Missing required properties: 'vddi-supply', 'avdd-supply', 'avee-supply'

3. shikra-iqs-evk.dtb: display-subsystem@5e00000 (qcom,shikra-mdss):
   iommus: [[31, 1056, 2]] is too short

Fix:

  1. Fix missing label in shikra-cqs-evk.dts:136:

    • The label usb_qmpphy_out is referenced but not defined. Either:
      • Define the label in the USB QMP PHY node, OR
      • Remove/comment the reference if USB support is not yet ready for this board

  2. Fix panel binding in shikra-cqm-evk.dts:

    • Add fallback compatible: compatible = "dlc,dlc0697", "ilitek,ili7807s";
    • Rename supplies to match schema:
      • vddio-supply → vddi-supply
      • Add missing avdd-supply and avee-supply
    • Remove bias-supply and enable-gpios if not in schema, or update the binding YAML

  3. Fix MDSS iommus property:

    • The iommus property expects more than 3 elements. Check qcom,qcm2290-mdss.yaml schema for the correct format (likely needs additional IOMMU stream IDs)

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqs-evk.dtb
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: 9 commits lack the required subject prefix (UPSTREAM:, FROMLIST:, BACKPORT:, or FROMGIT:), and 2 FROMLIST commits have patch content that differs from the upstream lore.kernel.org link referenced in the commit message.

Failure details:

Commits missing required prefix (9):
1. clk: qcom: Revert older series Shikra GPUCC/DISPCC changes
2. dt-bindings: display: panel: add Ilitek ILI7807S panel controller
3. drm/panel: add Ilitek ILI7807S panel driver
4. dt-bindings: display: msm: qcm2290: Add Shikra MDSS
5. soc: qcom: ubwc: Add Shikra UBWC config
6. arm64: dts: qcom: shikra: Add MDSS display subsystem
7. arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
8. arm64: defconfig: Enable ILI7807S DSI panel driver
9. arm64: dts: qcom: shikra-cqs-evk: Enable display

Commits with content mismatch (2):
- FROMLIST: dt-bindings: clock: qcom: Add the definition for the USB3 DP PHY reset
- FROMLIST: clk: qcom: gcc-shikra: Add USB3 DP PHY reset and LPASS clocks
  → "Change is different from the one mentioned in Link"

Fix:

  1. Add required prefix to 9 commits:

    • If these are Qualcomm-internal changes not intended for upstream: prefix with QCOM: or similar internal tag
    • If these are new patches being prepared for upstream: prefix with FROMLIST: and add a Link: tag to the lore.kernel.org posting
    • If reverting previous work: consider REVERT: or QCOM: prefix

  2. Fix content mismatch for 2 FROMLIST commits:

    • Option A: Update the Link: tag to point to the correct upstream version that matches the patch content
    • Option B: Revert local changes to match the upstream patch exactly, then apply local modifications as separate commits with appropriate prefixes

Reproduce locally:

# Check for required prefixes
git log --oneline HEAD~28..HEAD | grep -v -E "^[0-9a-f]+ (UPSTREAM|FROMLIST|BACKPORT|FROMGIT|QCOM):"

# Validate FROMLIST commits against lore links
# (requires check-patch-compliance script from kernel-config repo)

Verdict

11 blockers must be fixed before merge:

  1. Checkpatch (13 commits): Remove all Gerrit Change-Id: trailers
  2. Checkpatch (1 commit): Fix tab indentation in YAML binding
  3. dtb-check (critical): Fix undefined usb_qmpphy_out label in shikra-cqs-evk.dts
  4. dtb-check (schema): Fix panel compatible, supplies, and MDSS iommus properties
  5. check-patch-compliance (9 commits): Add required subject prefixes
  6. check-patch-compliance (2 commits): Resolve FROMLIST content mismatch with upstream links

Recommended workflow:

  1. Fix the critical DTS syntax error first (blocker for dtb-check)
  2. Remove Gerrit Change-IDs and fix indentation (automated fixes)
  3. Add missing subject prefixes (policy decision needed: QCOM: vs FROMLIST:)
  4. Resolve FROMLIST content mismatches
  5. Fix remaining schema validation issues
  6. Re-run CI to verify all checkers pass

@naala-qcom

naala-qcom commented Jun 10, 2026

Copy link
Copy Markdown
Author

qli-2.0 GA Critical Fix

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4566067 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4566067

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4566067 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4566067

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@sgaud-quic

sgaud-quic commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@naala-qcom please rebase the PR on tip.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

shashim-quic
shashim-quic requested changes Jun 10, 2026
View reviewed changes

@shashim-quic shashim-quic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • prefix all commits with valid tags (FROMLIST etc.)
  • include a valid Link: tag in commit log

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qcomlnxci qcomlnxci requested a review from a team June 11, 2026 05:15
@qswat-orbit-external

qswat-orbit-external Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

3 similar comments
@qswat-orbit-external

qswat-orbit-external Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 14, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

qswat-orbit-external Bot commented Jun 15, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@naala-qcom naala-qcom requested a review from shashim-quic June 16, 2026 06:32
Komal-Bajaj
Komal-Bajaj reviewed Jun 18, 2026
View reviewed changes
Comment thread arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts Outdated
status = "okay";
};

&tlmm {

@Komal-Bajaj Komal-Bajaj Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tlmm node is referenced at line 230, use same tlmm node to add these states

also, do maintain alphabetical order

Komal-Bajaj
Komal-Bajaj reviewed Jun 18, 2026
View reviewed changes
Comment thread arch/arm64/configs/defconfig
Komal-Bajaj
Komal-Bajaj reviewed Jun 18, 2026
View reviewed changes
Comment thread arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
@qcomlnxci qcomlnxci requested a review from a team June 18, 2026 12:19
@naala-qcom naala-qcom requested a review from Komal-Bajaj June 18, 2026 12:42
@naala-qcom naala-qcom force-pushed the dt-changes branch 2 times, most recently from 6c88d45 to f05966c Compare June 18, 2026 17:30
Komal-Bajaj
Komal-Bajaj previously approved these changes Jun 18, 2026
View reviewed changes
@qlijarvis

qlijarvis commented Jun 18, 2026

Copy link
Copy Markdown

PR #679 — validate-patch

PR: #679

Verdict Issues Detailed Report
⚠️ 7 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patches not yet posted to mailing lists; no lore link expected at this stage

  2. Lore link matches PR commits: N/A — no lore link to compare against; these are pre-submission patches

  3. Upstream patch status: Not upstream — PENDING: prefix confirms these patches are being prepared for upstream submission but have not been posted to linux-arm-msm or devicetree mailing lists yet

  4. PR present in qcom-next: Not checked — PENDING: patches are typically staged in topic branches before integration into qcom-next; this is expected workflow for pre-upstream patches

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #679 - Add MDSS display subsystem support for Shikra
Upstream commit: N/A (PENDING: patches not yet posted)
Verdict: ⚠️ PARTIAL

Commit Message

Patch 1/4: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale ✅ Clear description of hardware and fallback strategy
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ✅ nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A New feature for Shikra platform

Patch 2/4: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale ✅ Explains board enablement and regulator constraint
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ✅ nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A New feature for Shikra CQM EVK

Patch 3/4: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale ✅ Explains panel driver enablement for Shikra CQM EVK
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Email changed to naala@qti.qualcomm.com
Backport note (if applicable) N/A New defconfig entry

Patch 4/4: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale ✅ Brief but clear description
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Email changed to naala@qti.qualcomm.com
Backport note (if applicable) N/A New feature for Shikra CQS EVK

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Clean MDSS/DPU/DSI node additions with proper compatible strings
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ✅ Board-level display enablement with panel and regulators
arch/arm64/configs/defconfig ✅ Single CONFIG line added in alphabetical order
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ✅ Board-level display enablement (mirrors CQM EVK pattern)

Issues

Authorship Inconsistency:

  • Patches 1-2 use nabige.aala@oss.qualcomm.com
  • Patches 3-4 use naala@qti.qualcomm.com
  • Impact: This inconsistency may cause confusion during upstream review and makes it unclear which email should be used for correspondence. The author should use a single, consistent email address across the entire series.

PENDING: Prefix:

  • All commits carry the PENDING: prefix, which is a Qualcomm internal convention
  • Impact: This prefix must be removed before posting to upstream mailing lists (linux-arm-msm, devicetree, etc.). The prefix is acceptable for internal review but will be rejected upstream.

No Cover Letter Context:

  • A 4-patch series adding display support would benefit from a cover letter (0/4) explaining the overall goal, hardware details, and testing performed
  • Impact: Upstream reviewers will appreciate context about the Shikra platform and how this series fits into the broader enablement effort

Verdict

Acceptable for internal review with minor corrections needed before upstream submission. The patches are well-structured with clear commit messages and clean diffs. However, the author must (1) unify email addresses across all commits, and (2) remove the PENDING: prefix before posting upstream.

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patches not yet posted to mailing lists; no lore link expected at this stage

  2. Lore link matches PR commits: N/A — no lore link to compare against; these are pre-submission patches

  3. Upstream patch status: Not upstream — PENDING: prefix confirms these patches are being prepared for upstream submission but have not been posted to linux-arm-msm or devicetree mailing lists yet

  4. PR present in qcom-next: Not checked — PENDING: patches are typically staged in topic branches before integration into qcom-next; this is expected workflow for pre-upstream patches

@qlijarvis

qlijarvis commented Jun 18, 2026

Copy link
Copy Markdown

PR #679 — checker-log-analyzer

PR: #679
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27777670110

Checker Result Summary
Checker Result Summary
checkpatch ✅ All 4 commits pass with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ❌ 2 schema validation errors across all board DTBs
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance ❌ All 4 commits use PENDING: prefix (not FROMLIST:/UPSTREAM:)
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ PENDING: commits require FROMLIST:/UPSTREAM: for qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #679 - PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem (4 commits)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27777670110

Checker Result Summary
checkpatch ✅ All 4 commits pass with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ❌ 2 schema validation errors across all board DTBs
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance ❌ All 4 commits use PENDING: prefix (not FROMLIST:/UPSTREAM:)
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ PENDING: commits require FROMLIST:/UPSTREAM: for qcom-next

❌ dtb-check

Root cause: The iommus property in the MDSS node has only 3 cells <&apps_smmu 0x420 0x2>, but the qcom,qcm2290-mdss.yaml schema expects 4 cells per IOMMU entry.

Failure details:

display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[41, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#

panel@0 (dlc,dlc0697): compatible: ['dlc,dlc0697'] is too short
	from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili7807s.yaml#

Affects all board DTBs: shikra-cqm-evk, shikra-cqs-evk, shikra-iqs-evk (and their camera variants).

Fix:

  1. IOMMU property fix: The qcom,qcm2290-mdss binding expects 4 cells per IOMMU specifier (phandle + 3 cells). Change:

    - iommus = <&apps_smmu 0x420 0x2>;
+ iommus = <&apps_smmu 0x420 0x0 0x2>;

    The middle cell is typically the SID mask (0x0 for no masking).

  2. Panel compatible fix: The ilitek,ili7807s.yaml schema requires a fallback compatible. The panel node should have:

    - compatible = "dlc,dlc0697";
+ compatible = "dlc,dlc0697", "ilitek,ili7807s";

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: prefix, which is not a valid upstream tag for the kernel-checker compliance check.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
Commit summary does not start with a required prefix

Fix:

The check-patch-compliance checker requires commits to use one of these prefixes:

  • UPSTREAM: - for patches already merged in mainline
  • FROMLIST: - for patches posted to upstream mailing lists but not yet merged
  • BACKPORT: - for backported patches with modifications

Since these are new patches for Shikra (a Qualcomm-specific platform), they should use:

FROMLIST: arm64: dts: qcom: shikra: Add MDSS display subsystem

If these patches have been posted to the linux-arm-msm mailing list, include the lore.kernel.org link in the commit message footer.

Reproduce locally:

# Clone kernel-checkers repo
git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel --base <base-sha> --head <head-sha>

Verdict

2 blockers must be fixed before merge:

  1. dtb-check: Fix IOMMU property (add 4th cell) and panel compatible (add fallback) in arch/arm64/boot/dts/qcom/shikra.dtsi and board DTS files
  2. check-patch-compliance: Replace PENDING: prefix with FROMLIST: or UPSTREAM: in all 4 commit messages

The checkpatch, dt-binding-check, sparse-check, and check-uapi-headers all pass or are correctly skipped.

@qcomlnxci

qcomlnxci commented Jun 18, 2026

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️

@qcomlnxci

qcomlnxci commented Jun 18, 2026

Copy link
Copy Markdown

Test jobs on f05966c

Nabige Aala and others added 4 commits June 19, 2026 12:14
@naala-qcom
PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
6a1cc87 
Add the SoC-level display subsystem nodes for Shikra: MDSS wrapper,
DPU display controller, DSI host controller, and 14nm DSI PHY.

Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific
compatible strings are used as the primary match with QCM2290 fallbacks
to reuse the existing driver support.

The dispcc clock inputs for the DSI byte and pixel PLLs are wired
from mdss_dsi0_phy.

Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
@naala-qcom
PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili…
332d301 
…7807s panel

Enable the Shikra MDSS display subsystem on the CQM EVK
board and add the ili7807s panel node. Pin pm4125_l5 to
1.232V with regulator-allow-set-load for DSI PHY PLL
stability.

Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
@naala-qcom
PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
14379d5 
Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
used on the Shikra CQM EVK board.

Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>
@naala-qcom
PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
a8f46a8 
Enable the DLC0697 MIPI DSI display panel on the Shikra
CQS EVK.

Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>
@naala-qcom naala-qcom requested a review from Komal-Bajaj June 19, 2026 07:05
@qcomlnxci qcomlnxci requested a review from a team June 19, 2026 07:06
@qlijarvis

qlijarvis commented Jun 19, 2026

Copy link
Copy Markdown

PR #679 — validate-patch

PR: #679

Verdict Issues Detailed Report
⚠️ 12 Full report

Final Summary

  1. Lore link present: No — All commits have "PENDING:" prefix; no lore links in commit messages
  2. Lore link matches PR commits: N/A — No lore links to compare against
  3. Upstream patch status: Not upstream — "PENDING:" prefix indicates patches not yet posted to mailing lists
  4. PR present in qcom-next: Not checked — PENDING: work-in-progress series not ready for stable integration

Recommendation: This appears to be a vendor-tree development series for Shikra display support. Before merging:

  • Verify ILI7807S panel driver availability
  • Standardize author email across all patches
  • Remove "PENDING:" prefix when ready
  • Consider posting to upstream (linux-arm-msm, dri-devel) if targeting mainline
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #679 - Add MDSS display subsystem support for Shikra
Upstream commit: N/A (PENDING: prefix indicates not yet posted)
Verdict: ⚠️ PARTIAL

Commit Message Analysis

Patch 1/4: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Check Status Note
Subject matches upstream N/A Not posted upstream yet
Body preserves rationale ✅ Clear description of hardware and fallback strategy
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Uses nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A New feature for vendor tree

Patch 2/4: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Check Status Note
Subject matches upstream N/A Not posted upstream yet
Body preserves rationale ✅ Explains board enablement and voltage requirement
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Uses nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A New feature for vendor tree

Patch 3/4: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Check Status Note
Subject matches upstream N/A Not posted upstream yet
Body preserves rationale ✅ Explains module enablement for specific board
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Uses naala@qti.qualcomm.com (different from 1-2)
Backport note (if applicable) N/A New feature for vendor tree

Patch 4/4: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Check Status Note
Subject matches upstream N/A Not posted upstream yet
Body preserves rationale ✅ Brief but adequate for board enablement
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Uses naala@qti.qualcomm.com (different from 1-2)
Backport note (if applicable) N/A New feature for vendor tree

Diff Analysis

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Well-structured MDSS/DPU/DSI nodes with proper bindings
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ✅ Board-level panel and regulator enablement
arch/arm64/configs/defconfig ✅ Single Kconfig addition in alphabetical order
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ✅ Board-level panel enablement (duplicate of CQM pattern)

Issues

Authorship Inconsistency:

  • Patches 1-2 use nabige.aala@oss.qualcomm.com
  • Patches 3-4 use naala@qti.qualcomm.com
  • This inconsistency should be resolved before upstream submission. Typically, a single author email should be used throughout a series unless there are multiple co-authors.

PENDING: Prefix:

  • All commits carry "PENDING:" prefix, indicating work-in-progress status
  • This prefix should be removed before upstream submission
  • No lore.kernel.org links are present in commit messages

Missing Upstream Context:

  • No indication whether the ILI7807S panel driver (CONFIG_DRM_PANEL_ILITEK_ILI7807S) exists upstream
  • If the panel driver is not yet upstream, patch 3/4 (defconfig) cannot be merged until the driver lands
  • The compatible string "ilitek,ili7807s" must have corresponding driver and DT binding documentation

Commit Message Quality:

  • Commit messages are well-written and follow kernel style
  • Adequate technical detail provided for device tree additions
  • Rationale for voltage settings and hardware configuration is present

Verdict

Cannot merge as-is. This series requires:

  1. Resolution of author email inconsistency across the series
  2. Verification that ILI7807S panel driver exists (either upstream or in this tree)
  3. Removal of "PENDING:" prefix when ready for integration
  4. Confirmation that DT bindings for all new compatible strings are documented

The technical content appears sound, but the series is clearly marked as work-in-progress and needs upstream posting/acceptance before integration into a stable branch.

Final Summary

  1. Lore link present: No — All commits have "PENDING:" prefix; no lore links in commit messages
  2. Lore link matches PR commits: N/A — No lore links to compare against
  3. Upstream patch status: Not upstream — "PENDING:" prefix indicates patches not yet posted to mailing lists
  4. PR present in qcom-next: Not checked — PENDING: work-in-progress series not ready for stable integration

Recommendation: This appears to be a vendor-tree development series for Shikra display support. Before merging:

  • Verify ILI7807S panel driver availability
  • Standardize author email across all patches
  • Remove "PENDING:" prefix when ready
  • Consider posting to upstream (linux-arm-msm, dri-devel) if targeting mainline

@qlijarvis

qlijarvis commented Jun 19, 2026

Copy link
Copy Markdown

PR #679 — checker-log-analyzer

PR: #679
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27811006742

Checker Result Summary
Checker Result Summary
checkpatch ✅ All 4 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ❌ False positive: pre-existing warnings on unrelated nodes (pcie, mmc, ethernet) triggered by line number shifts
sparse-check ⏭️ Skipped - no C source changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance ❌ All 4 commits use "PENDING:" prefix instead of required UPSTREAM:/FROMLIST:/BACKPORT:
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #679 - PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27811006742

Checker Result Summary
checkpatch ✅ All 4 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check ❌ False positive: pre-existing warnings on unrelated nodes (pcie, mmc, ethernet) triggered by line number shifts
sparse-check ⏭️ Skipped - no C source changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance ❌ All 4 commits use "PENDING:" prefix instead of required UPSTREAM:/FROMLIST:/BACKPORT:
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: All four commits use the "PENDING:" prefix, which is not a recognized compliance tag.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
Commit summary does not start with a required prefix

Fix: Replace "PENDING:" with one of the required prefixes:

  • UPSTREAM: if the patch is already merged in mainline Linux
  • FROMLIST: if the patch is posted to a mailing list but not yet merged
  • BACKPORT: if the patch is being backported from another branch
  • Remove the prefix entirely if this is original work for the Qualcomm tree

Reproduce locally:

cd /path/to/kernel
git log --oneline -4 HEAD
# Check each commit subject starts with UPSTREAM:/FROMLIST:/BACKPORT:

❌ dtb-check (False Positive)

Root cause: The dtb-check script reports "new" warnings at shikra.dtsi:3569 for pcie@45e8000, mmc@4784000, and ethernet@5d00000/5d20000 nodes. However, this PR only adds MDSS display subsystem nodes around lines 2995-3200. The warnings are pre-existing issues that appear "new" because the PR's 200+ line insertion shifted all subsequent line numbers by ~200 lines.

Failure details:

../arch/arm64/boot/dts/qcom/shikra.dtsi:3569.4-27: Warning (interrupts_property): /soc@0/pcie@45e8000:#interrupt-cells: size is (108), expected multiple of 16
../arch/arm64/boot/dts/qcom/shikra.dtsi:3569.4-27: Warning (interrupts_property): /soc@0/mmc@4784000:#interrupt-cells: size is (24), expected multiple of 16
../arch/arm64/boot/dts/qcom/shikra.dtsi:3569.4-27: Warning (interrupts_property): /soc@0/ethernet@5d00000:#interrupt-cells: size is (12), expected multiple of 16
../arch/arm64/boot/dts/qcom/shikra.dtsi:3569.4-27: Warning (interrupts_property): /soc@0/ethernet@5d20000:#interrupt-cells: size is (12), expected multiple of 16

Analysis:

  • This PR adds mdss: display-subsystem@5e00000 and related nodes (DPU, DSI, PHY)
  • The warnings reference pcie@45e8000, mmc@4784000, ethernet@5d00000/5d20000 — none of which are touched by this PR
  • The dtb-check script uses grep -vFf base_dtbs_errors.log head_dtbs_errors.log to find new errors, but this is sensitive to line number changes
  • These warnings existed before this PR but at different line numbers (likely ~3369 before the +200 line insertion)

Fix: This is a known limitation of the dtb-check script. The warnings are not caused by this PR. Options:

  1. Recommended: Acknowledge this as a false positive and proceed with merge if check-patch-compliance is fixed
  2. Fix the underlying interrupt-cells issues in pcie/mmc/ethernet nodes in a separate PR (but this is unrelated to the display subsystem work)
  3. Request maintainer override for the dtb-check failure

Reproduce locally:

cd /path/to/kernel
# Check base branch
git checkout qcom-6.18.y
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqm-evk.dtb 2>&1 | grep "shikra.dtsi.*interrupt"

# Check with PR
git checkout <pr-branch>
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqm-evk.dtb 2>&1 | grep "shikra.dtsi.*interrupt"
# Compare line numbers - warnings should exist in both, just at different lines

Verdict

1 blocker to fix: check-patch-compliance failure requires updating commit subject prefixes from "PENDING:" to UPSTREAM:/FROMLIST:/BACKPORT: or removing the prefix.

dtb-check failure is a false positive caused by line number shifts and does not indicate any issue with the MDSS display subsystem code added by this PR.

@qcomlnxci

qcomlnxci commented Jun 19, 2026

Copy link
Copy Markdown

Test jobs on a8f46a8

@qcomlnxci

qcomlnxci commented Jun 19, 2026

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@sgaud-quic sgaud-quic merged commit 6221244 into qualcomm-linux:qcom-6.18.y Jun 19, 2026
6 of 8 checks passed
sgaud-quic added a commit to sgaud-quic/kernel that referenced this pull request Jun 21, 2026
@sgaud-quic
Revert "Add Shikra (QCM2390) display support for CQS and CQM targets (q…
e25ce0c 
…ualcomm-linux#679)"

Display is non-functional on Shikra (QCM2390) with the DTS nodes added
for CQS and CQM targets. Revert the MDSS display subsystem nodes from
shikra.dtsi, shikra-cqs-evk.dts, and shikra-cqm-evk.dts, and drop the
corresponding DRM_MSM Kconfig selection from defconfig until the root
cause is identified and fixed.

Reverts: 6221244 until proper fix is made for display enablement.

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
@sgaud-quic sgaud-quic mentioned this pull request Jun 21, 2026
Merged
sgaud-quic added a commit that referenced this pull request Jun 21, 2026
@sgaud-quic
Revert "Add Shikra (QCM2390) display support for CQS and CQM targets (#…
acc3e66 
…679)" #747

Revert "Add Shikra (QCM2390) display support for CQS and CQM targets (#679)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shashim-quic shashim-quic shashim-quic approved these changes

@quic-kaushalk quic-kaushalk Awaiting requested review from quic-kaushalk quic-kaushalk was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@aiquny aiquny Awaiting requested review from aiquny aiquny was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@Komal-Bajaj Komal-Bajaj Awaiting requested review from Komal-Bajaj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

qli-2.0 GA pull-request freeze

Development

Successfully merging this pull request may close these issues.

6 participants

@naala-qcom @qlijarvis @sgaud-quic @qcomlnxci @Komal-Bajaj @shashim-quic