qcom-rtss-mailbox-kmd: add recipe for RTSS mailbox kernel driver#2528
qcom-rtss-mailbox-kmd: add recipe for RTSS mailbox kernel driver#2528snegi-qti wants to merge 1 commit into
Conversation
snegi-qti
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti and
vkraleti
as code owners
|
Repo is not even public: https://github.com/qualcomm-linux/rtss-mailbox-kmd |
snegi-qti
force-pushed
the
rtss_kmd
branch
2 times, most recently
from
be5f40d to
90ca377
Compare
|
Sure, we are very close on making the repo public - awaiting some approvals, meanwhile, we can keep this as draft. |
Test Results 105 files + 79 634 suites +608 5h 16m 59s ⏱️ + 4h 21m 49s Results for commit ebfa959. ± Comparison against base commit f3eeb8b. This pull request removes 2 and adds 114 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The RTSS subsystem communicates with the application processor over a mailbox IPC channel. Add a recipe for the RTSS mailbox DLKM, which provides the kernel-side mailbox driver. Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
|
qli-2.0 GA Critical Fix |
It's not a Fix. It's a new features, submitted past the cut-off date. |
| @@ -0,0 +1,39 @@ | |||
| # SPDX-License-Identifier: GPL-2.0-only | |||
| # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | |||
There was a problem hiding this comment.
Drop this copyright part, not required for the recipe.
| # SPDX-License-Identifier: GPL-2.0-only | ||
| # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
|
|
||
| inherit module |
There was a problem hiding this comment.
Move this part after SRCREV.
| # Module metadata | ||
| RPROVIDES:${PN} += "kernel-module-rtss-mailbox" | ||
|
|
||
| # Build configuration |
There was a problem hiding this comment.
Drop this comment,.
| SRC_URI = "git://github.com/qualcomm-linux/rtss-mailbox-kmd.git;branch=rtss-mailbox-kernel.le.0.0;protocol=https" | ||
| SRCREV = "74f4ec17e45a65e455c2bff33638b5c5a7c507e0" | ||
|
|
||
| # Module metadata |
| MAKE_TARGETS = "modules" | ||
| MODULES_INSTALL_TARGET = "modules_install" | ||
|
|
||
| # Auto-load module on boot |
| LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/${LICENSE};md5=801f80980d171dd6425610833a22dbe6" | ||
|
|
||
| SRC_URI = "git://github.com/qualcomm-linux/rtss-mailbox-kmd.git;branch=rtss-mailbox-kernel.le.0.0;protocol=https" | ||
| SRCREV = "74f4ec17e45a65e455c2bff33638b5c5a7c507e0" |
There was a problem hiding this comment.
Please create a tag/release and use that instead of just a hash here (and then map the recipe version properly, instead of using _git.
ricardosalveti
left a comment
ricardosalveti
left a comment
There was a problem hiding this comment.
Please improve your commit message, explain why this module is needed in first place, how it is going to be used, by which components, etc.
3 participants
The RTSS (Real Time Subsystem) subsystem communicates with the application processor over a mailbox IPC channel. Add a recipe for the RTSS mailbox DLKM, which provides the kernel-side mailbox driver.