Add: Qualcomm User Data Encryption test script & Document - #141
Merged
Conversation
xbharani
commented
Aug 11, 2025
xbharani
commented
Contributor
- Checks for fscryptctl binary presence
- Creates a random sw encryption key
- Applies and verifies encryption policy
- Confirms functionality with a test file
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
Contributor
|
xbharani Any update on the requested changes? |
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
Srikanth Muppandam (smuppand)
requested changes
Oct 28, 2025
xbharani
force-pushed
the
main
branch
2 times, most recently
from
November 20, 2025 09:52
bd6eccf to
56d715d
Compare
Srikanth Muppandam (smuppand)
requested changes
Nov 25, 2025
xbharani
force-pushed
the
main
branch
2 times, most recently
from
December 8, 2025 05:26
686cf9f to
8f29437
Compare
Srikanth Muppandam (smuppand)
requested changes
Dec 8, 2025
Srikanth Muppandam (smuppand)
requested changes
Dec 19, 2025
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
the script is close, but a few things will bite in CI / reliability, plus a couple of correctness/safety issues.
Srikanth Muppandam (smuppand)
requested changes
Dec 23, 2025
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
A few additional minor changes are required. Other than that, everything appears to be fine.
Srikanth Muppandam (smuppand)
requested changes
Jan 2, 2026
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
Few nice to have changes
Srikanth Muppandam (smuppand)
requested changes
Jan 5, 2026
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
Still few must fix items.
| log_info "Created unique mount directory: $MOUNT_DIR" | ||
|
|
||
|
|
||
| FS_PATH=$(df --output=target "$MOUNT_DIR" | tail -n 1) |
Contributor
There was a problem hiding this comment.
if there's any chance of a busybox/ non-GNU environment, just be aware --output=target may not exist. Given the meta-qcom target, it's probably fine. If we want to be ultra-portable in future, this part might be abstracted into hlper, but for now it's acceptable.
Still it is not addressed. This is ok most of the time. But it can include leading spaces depending on the df output formatting.
safer
FS_PATH="$(df --output=target "$MOUNT_DIR" 2>/dev/null | awk 'NR==2{print $1}')"
Srikanth Muppandam (smuppand)
requested changes
Jan 8, 2026
Srikanth Muppandam (smuppand)
requested changes
Jan 13, 2026
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
Minor NIT changes.
Srikanth Muppandam (smuppand)
requested changes
Jan 14, 2026
Contributor
|
xbharani please respond to the comments where you have addressed. Otherwise it is hard to find what has been addressed. |
- Checks for fscryptctl binary presence - Creates a random sw encryption key - Applies and verifies encryption policy - Confirms functionality with a test file - Added yaml config Signed-off-by: Bharani Bhuvanagiri <bbharani@qti.qualcomm.com>
Srikanth Muppandam (smuppand)
approved these changes
Jan 20, 2026
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Srikanth Muppandam (smuppand)
merged commit Jan 20, 2026
9ce0a72
into
qualcomm-linux:main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.