Add IGT display test wrappers with default binary paths - #535
Conversation
- added dmabuf test - Added kms_vblank test with subtest filtering (excludes suspend/rpm) - Added kms_sysfs_edid_timing test for EDID validation - Added kms_setmode test for mode setting validation - Created README.md documentation for all tests All tests now use /usr/libexec/igt-gpu-tools/ as default path and support optional binary path override via CLI arguments. Signed-off-by: Salipalli(Temp), Venkata Satya Raja Preetam Jagan <vsalipal@qti.qualcomm.com>
Signed-off-by: Salipalli(Temp), Venkata Satya Raja Preetam Jagan <vsalipal@qti.qualcomm.com>
|
vsalipal Squash the executable-permission repair into the feature commit. |
|
|
||
| log_info "Using dmabuf binary at: $DMABUF_CMD" | ||
|
|
||
| if ! weston_stop; then |
There was a problem hiding this comment.
All four wrappers stop Weston but never restart it on PASS, FAIL, or SKIP.
Follow core_auth/run.sh: source lib_display.sh, track weston_stopped_by_test, and call weston_restore_runtime on every exit path, including signals. The equivalent locations are kms_setmode:90, kms_sysfs_edid_timing:90, and kms_vblank:104.
| log_info "results will be written to \"$result_file\"" | ||
| log_info "-------------------Completed $TESTNAME Testcase----------------------------" | ||
|
|
||
| if [ "$RC" -ne 0 ]; then |
There was a problem hiding this comment.
Any nonzero return code is classified as FAIL before skip handling. IGT uses exit code 77 for skipped tests, as the README itself states.
Handle RC=77 before the general nonzero branch. Apply the same correction at kms_setmode:120, kms_sysfs_edid_timing:120, and kms_vblank:135.
|
|
||
| log_file="$test_path/${TESTNAME}_log.txt" | ||
| log_info "Running with arguments: $TEST_ARGS" | ||
| eval "$KMS_VBLANK_CMD $TEST_ARGS" > "$log_file" 2>&1 |
There was a problem hiding this comment.
Remove eval from command execution. Both the binary path and subtest pattern enter eval.
Store only the pattern and invoke "$KMS_VBLANK_CMD" --run-subtest "$RUN_SUBTEST" directly.
2 participants
All tests now use /usr/libexec/igt-gpu-tools/ as default path and support optional binary path override via CLI arguments.