Skip to content

Fix mem leak#340

Open
Eddie (0222826398) wants to merge 2 commits into
qualcomm:developmentfrom
0222826398:fix-mem-leak
Open

Fix mem leak#340
Eddie (0222826398) wants to merge 2 commits into
qualcomm:developmentfrom
0222826398:fix-mem-leak

Conversation

@0222826398

Copy link
Copy Markdown
Contributor

Free hi->name & h->name in cleanup path, and free pdname_uri in open path.
Add lock/unlock around pop loop in REVERSE_HANDLE_LIST_ID cleanup.
Add a new config deinit path to free FARF log filename buffers allocated during config init, ensuring init/deinit are paired.

Free hi->name & h->name in cleanup path, and free pdname_uri in open path.
Add lock/unlock around pop loop in REVERSE_HANDLE_LIST_ID cleanup.

Signed-off-by: Eddie Lin <yutlin@qti.qualcomm.com>
Add a new config deinit path to free FARF log filename buffers allocated during config init, ensuring init/deinit are paired.

Signed-off-by: Eddie Lin <yutlin@qti.qualcomm.com>
@lool

Copy link
Copy Markdown
Contributor

Eddie (@0222826398) Hi Eddie, your GitHub username looks suspicious; any chance you'd consider using some kind of name? Could you also join the qualcomm org so that we can confirm it's you?

@0222826398

Copy link
Copy Markdown
Contributor Author

Hi Loïc Minier (@lool), Thanks for the heads up! I’ve already joined the Qualcomm organization, and I’ve also updated my GitHub profile name to Eddie as requested. Please let me know if everything looks good now!

@lool

Copy link
Copy Markdown
Contributor

Hi Loïc Minier (@lool), Thanks for the heads up! I’ve already joined the Qualcomm organization, and I’ve also updated my GitHub profile name to Eddie as requested. Please let me know if everything looks good now!

I don't know if you can change it, but your all-digits username is also quite unusual and what made me pause in the first place

@0222826398

Copy link
Copy Markdown
Contributor Author

Hi Loïc Minier (@lool), Thanks for the heads up! I’ve already joined the Qualcomm organization, and I’ve also updated my GitHub profile name to Eddie as requested. Please let me know if everything looks good now!

I don't know if you can change it, but your all-digits username is also quite unusual and what made me pause in the first place

Hi Loïc Minier (@lool), Understood! Unfortunately, I am unable to change the underlying GitHub account username, but I have updated my profile's display name to Eddie for better identification. Thanks!
image

@quic-vkatoch Vinayak (quic-vkatoch) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anankulk

Copy link
Copy Markdown
Contributor

Test Matrix

Board Track Kernel Domain PD Mode Subtests Result
kaanapali-mtpMainline7.1.0-rc5ADSPSigned3/3✅ Pass
kaanapali-mtpMainline7.1.0-rc5CDSPSigned3/3✅ Pass
kaanapali-mtpMainline7.1.0-rc5CDSPUnsigned3/3✅ Pass
lemans-evkMainline7.1.0-rc5ADSPSigned3/3✅ Pass
lemans-evkMainline7.1.0-rc5CDSPSigned3/3✅ Pass
lemans-evkMainline7.1.0-rc5CDSPUnsigned3/3✅ Pass
lemans-evkMainline7.1.0-rc5CDSP1Signed3/3✅ Pass
lemans-evkMainline7.1.0-rc5CDSP1Unsigned3/3✅ Pass
qcs615-rideMainline7.1.0-rc5ADSPSigned3/3✅ Pass
qcs615-rideMainline7.1.0-rc5CDSPSigned3/3✅ Pass
qcs615-rideMainline7.1.0-rc5CDSPUnsigned3/3✅ Pass
qcs6490-rb3gen2Mainline7.1.0-rc5ADSPSigned3/3✅ Pass
qcs6490-rb3gen2Mainline7.1.0-rc5CDSPSigned3/3✅ Pass
qcs6490-rb3gen2Mainline7.1.0-rc5CDSPUnsigned3/3✅ Pass
qcs8300-rideMainline7.1.0-rc5ADSPSigned3/3✅ Pass
qcs8300-rideMainline7.1.0-rc5CDSPSigned3/3✅ Pass
qcs8300-rideMainline7.1.0-rc5CDSPUnsigned3/3✅ Pass
sm8750-mtpMainline7.1.0-rc5ADSPSigned3/3✅ Pass
sm8750-mtpMainline7.1.0-rc5CDSPSigned3/3✅ Pass
sm8750-mtpMainline7.1.0-rc5CDSPUnsigned3/3✅ Pass

Verification Note: Results verified on respective targets via automated LAVA testing (20/20 invocations passed, 60/60 subtests passed).


LAVA Jobs:

CI run: https://github.com/qualcomm-linux-stg/fastrpc-config/actions/runs/27345287828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants