Fix docs/google snippet error and add to snippets_test #7803
+79
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use test substitution to replace undefined variables 2. Use test substitution to replace cloud APIs with mock class 3. Fix EngineJob constructor Partially fix quantumlib#7787.
1. Use test substitution to replace undefined variables 2. Use test substitution to replace cloud APIs with mock class 3. Fix unexpected indent and import Partially fix quantumlib#7787.
1. Use test substitution to replace undefined variables 2. Use test substitution to replace cloud APIs with mock class 3. Fix outdated import paths Partially fix quantumlib#7787.
ToastCheng
requested review from
a team,
hoisinberg,
verult,
vtomole and
wcourtney
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7803 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 1102 1102
Lines 98529 98641 +112
==========================================
+ Hits 98109 98220 +111
- Misses 420 421 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add all md files under docs/google to run the snippets_test, also add necessary import (like cirq_google).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the md files' snippet errors under docs/google by adding test substitution and MagicMock, also fixing some outdated APIs. On the test side, adding necessary imports for cirq_google to let the tests being able to find necessary variables.