Skip to content

Add load density chart#484

Open
holly-cummins wants to merge 4 commits into
quarkusio:mainfrom
holly-cummins:add-load-density-chart
Open

Add load density chart#484
holly-cummins wants to merge 4 commits into
quarkusio:mainfrom
holly-cummins:add-load-density-chart

Conversation

@holly-cummins

Copy link
Copy Markdown
Contributor

I was going to explain the chart, then realised I shouldn't, to see if it's self-explanatory. :)

Money version coming in follow-on PR.

This builds on the commits from #40, so those commits don't need to be reviewed here.

github-actions Bot pushed a commit that referenced this pull request May 30, 2026
@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

🚀 This is what some of the generated images would look like with this change. You can browse the full set on the preview branch.

-images/tuned/spring-quarkus-perf-comparison-latest-tuned-load-density-for-all-dark.svg

-images/tuned/spring-quarkus-perf-comparison-latest-tuned-load-density-for-all-light.svg

-images/tuned/spring-quarkus-perf-comparison-latest-tuned-load-density-for-java-and-native-and-leyden-frameworks-dark.svg

-images/tuned/spring-quarkus-perf-comparison-latest-tuned-load-density-for-java-and-native-and-leyden-frameworks-light.svg

@holly-cummins

Copy link
Copy Markdown
Contributor Author

@edeandrea

Copy link
Copy Markdown
Collaborator

Should the number of instances lines be in front of the frameworks? As you get to the right I find it hard to correlate to number of instances.

holly-cummins and others added 2 commits May 30, 2026 17:58
FinePrint varargs constructor, Subcanvas.drawRect, Label index fix
from the bin-packing work.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@holly-cummins holly-cummins force-pushed the add-load-density-chart branch from bfb6533 to 3b0c600 Compare May 30, 2026 17:08
github-actions Bot pushed a commit that referenced this pull request May 30, 2026
@holly-cummins

Copy link
Copy Markdown
Contributor Author

Should the number of instances lines be in front of the frameworks? As you get to the right I find it hard to correlate to number of instances.

Ah, yes, I see what you mean - or translucent might look quite smart, will try that.

github-actions Bot pushed a commit that referenced this pull request May 30, 2026
github-actions Bot pushed a commit that referenced this pull request May 31, 2026
@holly-cummins

Copy link
Copy Markdown
Contributor Author

Updated to give the effect of transparent fill with visible gridlines. WDYT?

@edeandrea

Copy link
Copy Markdown
Collaborator

Updated to give the effect of transparent fill with visible gridlines. WDYT?

I think its better. What about about re-labeling the Y axis on the far right too?

@insectengine

Copy link
Copy Markdown

Updated to give the effect of transparent fill with visible gridlines. WDYT?

I think its better. What about about re-labeling the Y axis on the far right too?

I think that's an appropriate solution.

@holly-cummins

Copy link
Copy Markdown
Contributor Author

Updated to give the effect of transparent fill with visible gridlines. WDYT?

I think its better.

I do too. It was fiddlier than I expected, but as soon as I saw it working, I could see it was way better than the first pass. Yay for team collaboration!

What about about re-labeling the Y axis on the far right too?

Ooh, tricky. I have another PR that I'll raise once this one has settled that does cost, and on that one I use left and right. Do you think having the right-axis be instances is confusing on this one, if we have another one where the right axis is money? I'm genuinely not sure, and can't judge because I'm too close to it.

The good news is I have the code if we do want to do it...

image

@edeandrea

Copy link
Copy Markdown
Collaborator

Ooh, tricky. I have another PR that I'll raise once this one has settled that does cost, and on that one I use left and right. Do you think having the right-axis be instances is confusing on this one, if we have another one where the right axis is money? I'm genuinely not sure, and can't judge because I'm too close to it.

I go back and forth. I was suggesting the re-labelling because even though the foreground is transparent, its still hard to read. And as I get older my eyesight isn't as good and I find that I'm correlating with the wrong label on the left-side Y axis. Thats where my suggestion for re-labelling the Y axis on the right came from. Note - i meant the same label as on the left.

But now that I see both visualizations for # instances & cost I do like that. What about combining # instances & cost in a single label and putting on both the left & right? IDK if thats a good idea (I'm certainly not a good UX person).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants