Preserve herodevs_eol field in release sync script - #2890
Merged
Sanne merged 2 commits intoAug 4, 2026
Conversation
The automated release sync script was dropping `herodevs_eol` fields from releases.yaml because it only knew about `rhbq_eol` and `ibm_eol`. Changes: - Add herodevsEol field to Release class (supports both dates and strings like "nes") - Parse herodevs_eol in parseRelease() with flexible type handling - Preserve herodevs_eol when merging existing releases in createProcessedRelease() - Write herodevs_eol back to YAML in releaseToMap() - Update README.md to document herodevs_eol as a manually-edited field This ensures that when maintainers add `herodevs_eol: nes` to specific versions, those markers survive automated sync runs. Fixes the issue where herodevs_eol fields added in commit 9b67b63 were immediately removed by the next automated sync (commit ac0ccdc).
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
Contributor
Author
|
The dry run reporting in the updated sync shows: (no change - that's what we want). And https://quarkus-website-pr-2890-preview.surge.sh/releases/ shows herodevs again. |
Member
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automated release sync script was dropping
herodevs_eolfields from releases.yaml because it only knew aboutrhbq_eolandibm_eol.Changes:
This ensures that when maintainers add
herodevs_eol: nesto specific versions, those markers survive automated sync runs.Fixes the issue where herodevs_eol fields added in commit 9b67b63 were immediately removed by the next automated sync (commit ac0ccdc).